From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 779F84CAD2 for ; Tue, 13 Aug 2024 21:27:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E28BE68D997; Wed, 14 Aug 2024 00:27:19 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E9CB868D6C3 for ; Wed, 14 Aug 2024 00:27:12 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BD9BAC0004 for ; Tue, 13 Aug 2024 21:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723584431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PQnu1bghc3MFTTLu02kp0aDmpzAyc7jvGT26Pzgjy5g=; b=aJbGJnTpUg/NRwK5if5QfmagNupRX+ORwMIWgNklYJfeuDxCO/6ENKeAdpz3Oj30idKI0v icLz0JV4OYRvECdBbOzxMWdV/CnSN6Td50Uwp9OlzMDcEPVaVwupiAjx2J0G9sRwrOicm+ 4mYWbIDs/qhGtxrvD8xtwAmjcfSYjStLeP2q477qHyHZlTiSnwq5no37F/DzoiJdBvEVvH /IIl8NoJczcC9HT1tcJsQLYccvHphtH170EPlMrm/PMoRnxFKqkQBPdWxOjv9Pt6ayVgWq /N4e8A83pvyNy4sZxwcVEWc57IrlqTaXR+9746SFNeilEmcv0JjuClB2TPb0gA== Date: Tue, 13 Aug 2024 23:27:11 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240813212711.GP4991@pb2> References: <20240813142517.25219-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20240813142517.25219-1-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] swscale/output: don't leave the alpha channel undefined in vuyx and xv36le X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2427032813094665166==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2427032813094665166== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vy7kBIpA56vuXHtb" Content-Disposition: inline --vy7kBIpA56vuXHtb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 13, 2024 at 11:25:17AM -0300, James Almer wrote: > It's non-determistic, as shown by poisoning avfilter buffers instead of z= eroing them. >=20 > Signed-off-by: James Almer > --- > libswscale/output.c | 6 +++--- > tests/ref/fate/filter-pixfmts-copy | 4 ++-- > tests/ref/fate/filter-pixfmts-crop | 4 ++-- > tests/ref/fate/filter-pixfmts-field | 4 ++-- > tests/ref/fate/filter-pixfmts-fieldorder | 4 ++-- > tests/ref/fate/filter-pixfmts-hflip | 4 ++-- > tests/ref/fate/filter-pixfmts-il | 4 ++-- > tests/ref/fate/filter-pixfmts-null | 4 ++-- > tests/ref/fate/filter-pixfmts-pad | 2 +- > tests/ref/fate/filter-pixfmts-scale | 4 ++-- > tests/ref/fate/filter-pixfmts-transpose | 4 ++-- > tests/ref/fate/filter-pixfmts-vflip | 4 ++-- > 12 files changed, 24 insertions(+), 24 deletions(-) >=20 > diff --git a/libswscale/output.c b/libswscale/output.c > index e8dd2145ce..fb21e79f47 100644 > --- a/libswscale/output.c > +++ b/libswscale/output.c > @@ -2650,7 +2650,7 @@ yuv2xv36le_X_c(SwsContext *c, const int16_t *lumFil= ter, > { > int i; > for (i =3D 0; i < dstW; i++) { > - int Y =3D 1 << 14, U =3D 1 << 14, V =3D 1 << 14; > + int Y =3D 1 << 14, U =3D 1 << 14, V =3D 1 << 14, A =3D 255; > int j; > =20 > for (j =3D 0; j < lumFilterSize; j++) > @@ -2664,6 +2664,7 @@ yuv2xv36le_X_c(SwsContext *c, const int16_t *lumFil= ter, > AV_WL16(dest + 8 * i + 2, av_clip_uintp2(Y >> 15, 12) << 4); > AV_WL16(dest + 8 * i + 0, av_clip_uintp2(U >> 15, 12) << 4); > AV_WL16(dest + 8 * i + 4, av_clip_uintp2(V >> 15, 12) << 4); > + AV_WL16(dest + 8 * i + 6, A); > } > } > =20 > @@ -2718,8 +2719,7 @@ yuv2vuyX_X_c(SwsContext *c, const int16_t *lumFilte= r, > dest[4 * i ] =3D V; > dest[4 * i + 1] =3D U; > dest[4 * i + 2] =3D Y; > - if (destHasAlpha) > - dest[4 * i + 3] =3D A; > + dest[4 * i + 3] =3D A; > } > } probably ok thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The day soldiers stop bringing you their problems is the day you have stopp= ed=20 leading them. They have either lost confidence that you can help or conclud= ed=20 you do not care. Either case is a failure of leadership. - Colin Powell --vy7kBIpA56vuXHtb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrvPqwAKCRBhHseHBAsP q0khAJwLybANvWitYisCcsCJWC8mVr8pFwCgicuvdYVaNLyhCP+bU29v8BzV9UU= =IFxS -----END PGP SIGNATURE----- --vy7kBIpA56vuXHtb-- --===============2427032813094665166== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2427032813094665166==--