From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F00784C9AC for ; Sun, 11 Aug 2024 10:48:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E27D668D9A5; Sun, 11 Aug 2024 13:48:46 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8928F68D9A5 for ; Sun, 11 Aug 2024 13:48:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BD6901C0006 for ; Sun, 11 Aug 2024 10:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723373319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kG2y8ZU3q5MCMlQVzWfn8dvDcyT96msYadnzMvncZg4=; b=Mj83p9A8noP41CC4Y4Kk9A/OY9VpdB//S7rrXlsrDw2dTqDkkBaDNv4flcHEumZyr2fy56 lUaBdvE3/81rxksOfVmNzJm1uecNVWG/jNChcCKShNaKGTx6Xd8zpOM3T2Et9Mz2WMRn8I /YTjLLN7dFVi8nw3HPEkyU0CCjMGsGWssXd+t19uNFySmxDHxHEuBhv0M6IdXGwsxMLnZ5 eoFuDTUsws8Dzztnrke5Q6NtPc6YjrdYaIBxBSv067EdbgqFR48KriQc/3Fv/N15aMV9Tt PQ4B2q9riAe3zg6X8xx37w+jh8XrclaZ50ngJmwo7Ov0BwEEMEyrZmIq/VK4zg== Date: Sun, 11 Aug 2024 12:48:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240811104838.GK4991@pb2> References: <20240526235230.2876318-1-michael@niedermayer.cc> <20240526235230.2876318-4-michael@niedermayer.cc> <20240602202755.GA2821752@pb2> <20240707194840.GL4991@pb2> MIME-Version: 1.0 In-Reply-To: <20240707194840.GL4991@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1494333627188241547==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1494333627188241547== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M5LyoxStIw89BVAi" Content-Disposition: inline --M5LyoxStIw89BVAi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 07, 2024 at 09:48:40PM +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 10:27:55PM +0200, Michael Niedermayer wrote: > > On Sun, Jun 02, 2024 at 09:10:33PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > Fixes: CID1591924 Uninitialized scalar variable > > > > Fixes: CID1591938 Uninitialized scalar variable > > > >=20 > > > > Sponsored-by: Sovereign Tech Fund > > > > Signed-off-by: Michael Niedermayer > > > > --- > > > > libavcodec/dxva2.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c > > > > index 1a33c8bbac7..22ecd5acafe 100644 > > > > --- a/libavcodec/dxva2.c > > > > +++ b/libavcodec/dxva2.c > > > > @@ -906,7 +906,7 @@ int ff_dxva2_common_end_frame(AVCodecContext *a= vctx, AVFrame *frame, > > > > #endif > > > > DECODER_BUFFER_DESC *buffer =3D NULL, *buffer_slic= e =3D NULL; > > > > int result, runs =3D 0; > > > > - HRESULT hr; > > > > + HRESULT hr =3D -1; > > > > unsigned type; > > > > FFDXVASharedContext *sctx =3D DXVA_SHARED_CONTEXT(avctx); > > > > =20 > > >=20 > > > It seems to me that this (and other patches in this set) is not a real > > > fix of a bug. These functions are called either with a D3D11 pix fmt = or > > > with AV_PIX_FMT_DXVA2_VLD, so these variables are initialized before > > > their use. > >=20 > > If they are called with another pixel format then its exploitable > > maybe that cannot happen currently > >=20 > > But if or if not. Initializing these variables makes the code simply > > more robust and also if it happens a NULL is easier to debug than > > uninitialized variables. The assumtions that need to be true for > > them to be initialized are not entirely trivial. > >=20 > > ill drop the patches from what i wanted to apply currently but i still > > think they should be applied. >=20 > > I can change the commit message if you can suggest something else ? >=20 > ping > does anyone object to the patches ? > does someone want a different commit message ? if so which ? apparently noone cares so i will apply them with the "fixed" replaced by "related" or something like that thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Some people wanted to paint the bikeshed green, some blue and some pink. People argued and fought, when they finally agreed, only rust was left. --M5LyoxStIw89BVAi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZriXBgAKCRBhHseHBAsP q2hHAKCK/A0n2ufW6XEu9EA76POgw7RPJQCeOe4Sj3/Q7ZY7bwAvaZBUDj20QnM= =b0Cv -----END PGP SIGNATURE----- --M5LyoxStIw89BVAi-- --===============1494333627188241547== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1494333627188241547==--