From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avfilter/video: don't zero allocated buffers if memory poisoning is used
Date: Sat, 10 Aug 2024 21:32:46 -0300
Message-ID: <20240811003246.4334-1-jamrial@gmail.com> (raw)
Same as in avcodec/get_buffer.c
Should help in debugging use of uninitialized memory.
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavfilter/video.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavfilter/video.c b/libavfilter/video.c
index 89d0797ab5..afd3dc3dc3 100644
--- a/libavfilter/video.c
+++ b/libavfilter/video.c
@@ -71,8 +71,10 @@ AVFrame *ff_default_get_video_buffer2(AVFilterLink *link, int w, int h, int alig
}
if (!li->frame_pool) {
- li->frame_pool = ff_frame_pool_video_init(av_buffer_allocz, w, h,
- link->format, align);
+ li->frame_pool = ff_frame_pool_video_init(CONFIG_MEMORY_POISONING
+ ? NULL
+ : av_buffer_allocz,
+ w, h, link->format, align);
if (!li->frame_pool)
return NULL;
} else {
@@ -86,8 +88,10 @@ AVFrame *ff_default_get_video_buffer2(AVFilterLink *link, int w, int h, int alig
pool_format != link->format || pool_align != align) {
ff_frame_pool_uninit(&li->frame_pool);
- li->frame_pool = ff_frame_pool_video_init(av_buffer_allocz, w, h,
- link->format, align);
+ li->frame_pool = ff_frame_pool_video_init(CONFIG_MEMORY_POISONING
+ ? NULL
+ : av_buffer_allocz,
+ w, h, link->format, align);
if (!li->frame_pool)
return NULL;
}
--
2.46.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2024-08-11 0:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240811003246.4334-1-jamrial@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git