From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 748F54B5D7 for ; Thu, 8 Aug 2024 17:09:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6278768D97E; Thu, 8 Aug 2024 20:09:21 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E11D568D8A3 for ; Thu, 8 Aug 2024 20:09:14 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 25DEF1C0003 for ; Thu, 8 Aug 2024 17:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723136954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QZdIMuNUeI0ZUsl70x+2XuPKWP517zhgGSfTCU5NOQY=; b=UfVeVTqVkIzayruScN3zih+cd218Mu3pfn5p+fLJr/KbhUSm0tv0MM1gIdgL5wZu0n85Eb TMLYtZa2X2V3kfN4l8c9gVvQ5u7fxLe+TVbHCEHeHnualvAkO5Rl+HWeS9y1QUtzMKvovd zyCvboOgIqKqTlCqOiypPV3h2tpRIzDEHLL84LzMSVJjoCAjss1ksBUMkwVzHER1W0cP8n 4a/JBxhjAbff47+DPkAn/ss12IawE74blhZsuDQG5qpsE4J/3j5F6V7lYiNES1jmGCsCfW aIp2WBz6O2VWRN8dOvpFZzqZap/BdHM2p3v4mP28Y0VFCETTuCjX4zjccW6Llg== Date: Thu, 8 Aug 2024 19:09:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240808170913.GZ4991@pb2> References: <20240806221853.959177-1-michael@niedermayer.cc> <20240806221853.959177-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6228119544809104752==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6228119544809104752== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/TBPo/204fVdbBfe" Content-Disposition: inline --/TBPo/204fVdbBfe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 07, 2024 at 10:01:27AM +1000, Peter Ross wrote: > On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote: > > The code can leave uninitialized holes in the array. > > Fixes: use of uninitialized values > > Fixes: 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-66986= 94567591936 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/wtvdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c > > index e153034aa19..1a6c4c33481 100644 > > --- a/libavformat/wtvdec.c > > +++ b/libavformat/wtvdec.c > > @@ -185,7 +185,7 @@ static AVIOContext * wtvfile_open_sector(unsigned f= irst_sector, uint64_t length, > > int nb_sectors1 =3D read_ints(s->pb, sectors1, WTV_SECTOR_SIZE= / 4); > > int i; > > =20 > > - wf->sectors =3D av_malloc_array(nb_sectors1, 1 << WTV_SECTOR_B= ITS); > > + wf->sectors =3D av_calloc(nb_sectors1, 1 << WTV_SECTOR_BITS); > > if (!wf->sectors) { > > av_free(wf); > > return NULL; >=20 > agree, please apply will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. --/TBPo/204fVdbBfe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrT7tAAKCRBhHseHBAsP qyP/AJ9VAVPzr7jfk4an0GHsnaS3YjREeQCeMlZce/bvmiyTw6VHvxzRu14WE2o= =avfm -----END PGP SIGNATURE----- --/TBPo/204fVdbBfe-- --===============6228119544809104752== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6228119544809104752==--