Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1420 bytes --]

On Wed, Aug 07, 2024 at 10:01:27AM +1000, Peter Ross wrote:
> On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote:
> > The code can leave uninitialized holes in the array.
> > Fixes: use of uninitialized values
> > Fixes: 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6698694567591936
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/wtvdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c
> > index e153034aa19..1a6c4c33481 100644
> > --- a/libavformat/wtvdec.c
> > +++ b/libavformat/wtvdec.c
> > @@ -185,7 +185,7 @@ static AVIOContext * wtvfile_open_sector(unsigned first_sector, uint64_t length,
> >          int nb_sectors1 = read_ints(s->pb, sectors1, WTV_SECTOR_SIZE / 4);
> >          int i;
> >  
> > -        wf->sectors = av_malloc_array(nb_sectors1, 1 << WTV_SECTOR_BITS);
> > +        wf->sectors = av_calloc(nb_sectors1, 1 << WTV_SECTOR_BITS);
> >          if (!wf->sectors) {
> >              av_free(wf);
> >              return NULL;
> 
> agree, please apply

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".