From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 95A2C4B57F for ; Thu, 8 Aug 2024 16:09:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF2FE68D9B7; Thu, 8 Aug 2024 19:09:57 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B296368D92B for ; Thu, 8 Aug 2024 19:09:51 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id E9F4460006 for ; Thu, 8 Aug 2024 16:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723133391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LJLhHKIEBmOHnn5J+ffRd0Owlw5W8BE7YXOK0//C8lw=; b=gJBq5PojrRzpo7e+Hv394iMNJw5bwJ7GFzU7Ii7MrkQbI1MFN42AkcbaIjLs4bl+4hA0lE 1U0Wqo6unHrhPbLnRdjgRigI4mPEGb8Xgoh1AWc8Vu4ZO6r0kdARHtnInVTVrD6/VngEUZ 7/IXNjp4CJK5QPHF5nx0Rl66ou9Ex2ivNGf6A5rArJRhht4gBhsDcg3jPc/dfNZeCDVPaM eUoFDNOJpdEdEzY2Uy1CL+76QT2qWkKpAMw19twca6gjm3xiK66bT8DzgqthD4TLQKuRV4 ci0u45XsnlNLirPAwK6p6agsNuPQb7WgFnJ5lT7UDJah3bgEuREP5NNXr+QWgw== Date: Thu, 8 Aug 2024 18:09:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240808160949.GX4991@pb2> References: <20240807070301.nxz6653ipwtspr3y@nanos8.pcteor1.mi.infn.it> MIME-Version: 1.0 In-Reply-To: <20240807070301.nxz6653ipwtspr3y@nanos8.pcteor1.mi.infn.it> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] Extend the PATH buffer to 2048 for RTSP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3190062210558596713==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3190062210558596713== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pga57YAdUfKQcdIT" Content-Disposition: inline --Pga57YAdUfKQcdIT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 07, 2024 at 09:03:01AM +0200, Stefano Mandelli wrote: > Recently, I have been experiencing an increasing number > of user that use ffmpeg to retrive RTSP stream from > personal mediaproxies (e.g. MediaMtx) with > authorization based on JWT. The current length of PATH > does not permit to insert the token in the URL failing > the authorization with no possibilities to get the video. >=20 > VLC has just modified the RSTP max URL length, and it > permits to use token inside the URL. >=20 > For these reasons, I propose this patch to extend the > PATH buffer from 1024 to 2048 in order to use tokens > and the authorization process based on JWT. >=20 >=20 > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 19b93df839..d8f45cf8d5 100644 > --- a/libavformat/rtsp.c > +++ b/libavformat/rtsp.c > @@ -1727,7 +1727,7 @@ void ff_rtsp_close_connections(AVFormatContext *s) > int ff_rtsp_connect(AVFormatContext *s) > { > RTSPState *rt =3D s->priv_data; > - char proto[128], host[1024], path[1024]; > + char proto[128], host[1024], path[2048]; > char tcpname[1024], cmd[MAX_URL_SIZE], auth[128]; > const char *lower_rtsp_proto =3D "tcp"; > int port, err, tcp_fd; error: corrupt patch at line 13 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data --Pga57YAdUfKQcdIT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrTtzQAKCRBhHseHBAsP qxhaAKCRCxcpZ9uCs278HH2rEc25616cEQCePF2q5dlrQ2q3LzA1WZry3orOtO4= =YWZ4 -----END PGP SIGNATURE----- --Pga57YAdUfKQcdIT-- --===============3190062210558596713== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3190062210558596713==--