From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A381449359 for ; Tue, 6 Aug 2024 22:19:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C368268DAAA; Wed, 7 Aug 2024 01:19:05 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 12B0F68D9D2 for ; Wed, 7 Aug 2024 01:18:56 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 525E1240003 for ; Tue, 6 Aug 2024 22:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722982735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hePN5FbddE7mTLoehr9FVC5VtD/YwB3vuP50fNY038E=; b=M8Di+QV8x5tlOIGGbp/zaAJfenB8+c/f1oPOp+lmMGDbrvFbUTfUgOzhXk3vQNl6/7Pcxw NijlSQNRA+8LzZlmYKQHctqlLKXT1JnWJgMcKg55ak8XLlhaXeLe6i0TM3kMfuB8bOD7jv 9AdNH/WZkBxsMPvF8jqdRTVAL+HlOuJPcv2vOrQ+3/E9UnMTzSujZJXbjvXH00nC+NkdmK AjCagKkjrwp/JVycOoz1Zsi8rSnz0FCTt5lZsMvYuOk34tXlawZiF/OCQXfq7oNGlzX5RV W5bUQG7X1HC1vilFBYh+eRnBjFMKSp6/TZ8hapgcrSnA95DawSa24i2rzobShQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 7 Aug 2024 00:18:49 +0200 Message-ID: <20240806221853.959177-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240806221853.959177-1-michael@niedermayer.cc> References: <20240806221853.959177-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/6] avformat/av1dec: Check bits left before get_leb128() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes: use of uninitialized value Fixes: 70872/clusterfuzz-testcase-minimized-ffmpeg_dem_OBU_fuzzer-6005782487826432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/av1dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index 3363003b181..a5b620a0abf 100644 --- a/libavformat/av1dec.c +++ b/libavformat/av1dec.c @@ -326,6 +326,9 @@ static int read_obu_with_size(const uint8_t *buf, int buf_size, int64_t *obu_siz skip_bits(&gb, 3); // extension_header_reserved_3bits } + if (get_bits_left(&gb) < 8) + return AVERROR_INVALIDDATA; + *obu_size = get_leb128(&gb); if (*obu_size > INT_MAX) return AVERROR_INVALIDDATA; -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".