[FFmpeg-devel] [PATCH 2/6] avformat/av1dec: Check bits left before get_leb128()

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/6] avformat/av1dec: Check bits left before get_leb128()
Date: Wed,  7 Aug 2024 00:18:49 +0200
Message-ID: <20240806221853.959177-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20240806221853.959177-1-michael@niedermayer.cc>

Fixes: use of uninitialized value
Fixes: 70872/clusterfuzz-testcase-minimized-ffmpeg_dem_OBU_fuzzer-6005782487826432

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/av1dec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c
index 3363003b181..a5b620a0abf 100644
--- a/libavformat/av1dec.c
+++ b/libavformat/av1dec.c
@@ -326,6 +326,9 @@ static int read_obu_with_size(const uint8_t *buf, int buf_size, int64_t *obu_siz
         skip_bits(&gb, 3);  // extension_header_reserved_3bits
     }
 
+    if (get_bits_left(&gb) < 8)
+        return AVERROR_INVALIDDATA;
+
     *obu_size  = get_leb128(&gb);
     if (*obu_size > INT_MAX)
         return AVERROR_INVALIDDATA;
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
