From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 658EB4C809 for ; Tue, 6 Aug 2024 17:38:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6FAD068DA49; Tue, 6 Aug 2024 20:38:31 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CECE168D8B2 for ; Tue, 6 Aug 2024 20:38:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E77E60003 for ; Tue, 6 Aug 2024 17:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722965904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cgoMy8bVtUCHkGrAcvjaJVmUeusD0M5U6+FSAJ2W3l8=; b=CoKX1fz8J+HIlg0cjTR+hwPdOuNyyu26D7WDpgEcz7+o/0Ose+u/UqwUlMJcdvGgeGJaxy saZNxNlOIkScEoYJ8kpPL5MTIM7bif2Rcb7phSrZ8a6N+aWrmfDDI5AEuVAahqV4cjh2pr 2bb3tPeOBO2/sNRnT2p5kV93BqEPUKqiyOSlNH/sdKgPXZ5LIfd4CjIo5kecSvQY0qWlFR /rL7B810RSZaM5KOkR68ZKTvlVQxYhyqfrOZaXzFVMjdj9FFsthcGlj+ulXFRHeENyuc2o RQm8s7XO+twjBpqGcmSWujmHW/AtbeZANzOUSaDiwqC0OROZXlEalri03XfI6g== Date: Tue, 6 Aug 2024 19:38:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240806173823.GJ4991@pb2> References: <20240806170538.GI4991@pb2> MIME-Version: 1.0 In-Reply-To: <20240806170538.GI4991@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] CBS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8771008534600793012==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8771008534600793012== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w3kmj6YJmRtqQaLC" Content-Disposition: inline --w3kmj6YJmRtqQaLC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 06, 2024 at 07:05:38PM +0200, Michael Niedermayer wrote: > Hi >=20 > Did CBS win the obfuscated C contest yet? >=20 > I was just looking at a msan issue and then looked at this: >=20 > CHECK(FUNC_SEI(message_list)(ctx, rw, ¤t->message_list, 1)); >=20 >=20 > #define CHECK(call) do { \ > err =3D (call); \ > if (err < 0) \ > return err; \ > } while (0) >=20 > #define FUNC_NAME2(rw, codec, name) cbs_ ## codec ## _ ## rw ## _ ## name > #define FUNC_NAME1(rw, codec, name) FUNC_NAME2(rw, codec, name) > #define FUNC_H264(name) FUNC_NAME1(READWRITE, h264, name) > #define FUNC_H265(name) FUNC_NAME1(READWRITE, h265, name) > #define FUNC_H266(name) FUNC_NAME1(READWRITE, h266, name) > #define FUNC_SEI(name) FUNC_NAME1(READWRITE, sei, name) >=20 > #define SEI_FUNC(name, args) \ > static int FUNC(name) args; \ > static int FUNC(name ## _internal)(CodedBitstreamContext *ctx, \ > RWContext *rw, void *cur, \ > SEIMessageState *state) \ > { \ > return FUNC(name)(ctx, rw, cur, state); \ > } \ > static int FUNC(name) args >=20 >=20 > anyway, can we remove all preprocessor use from cbs ? the issue iam looking at is due to SEI_FUNC(sei_pic_timing, (CodedBitstreamContext *ctx, RWContext *rw, H264Ra= wSEIPicTiming *current, SEIMessageState *sei)) having different active SPS on writing than reading, so the write code has nal_hrd_parameters_present_flag set while the read had that 0 so uninitialized data is written I cannot find any match for "cbs" in MAINTAINERS, also there are no copyrig= ht with names in the cbs code. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. --w3kmj6YJmRtqQaLC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrJfiwAKCRBhHseHBAsP qwchAKCAorbCAOvPJtix8ZPyFD9h9ppWcgCdFoqtpN0FV+2cYFt0Q8dbpJ87ua0= =bZAQ -----END PGP SIGNATURE----- --w3kmj6YJmRtqQaLC-- --===============8771008534600793012== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8771008534600793012==--