From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36BE747440 for ; Mon, 5 Aug 2024 19:43:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFF0E68D737; Mon, 5 Aug 2024 22:43:34 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3DBE68D737 for ; Mon, 5 Aug 2024 22:43:28 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DCCD81C0004 for ; Mon, 5 Aug 2024 19:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722887008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FhloLXawbK6/6AqIzQ3faeUoGyD9dC50ngud5Q6hBjU=; b=YnmeUDDdmSyaLIYISwoQZPggc0IwlMgeOSREqm+vUBnKO7Srf9xHTPXygMIvRV1bqh+vdc OcVxFcheZY0VIbzJdOkEyJT7yAoRfgCJMdrwdlQC3NMvNoZr/tWoV5vM4oLPz/g5xWNWeT MYuCFSPrrMb919+lM2OZbIdYfWOiG1nuq01pXso+BuHbsw9vPVgE6V5by4wlLr6DC1D1gL dxn15RJfCXSbosnh43obpF4xhR0dgHIaeoDWJjbM+AeicJYc1n92JB1nToSBpFU3eZKsZn t+0BOvXAfZ/R2de6+9MDLJum1xKSiwqN5WcmznlcK3FxgIO8cUMGAdRVwIW3eA== Date: Mon, 5 Aug 2024 21:43:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240805194327.GF4991@pb2> References: <20240804205309.1978196-1-michael@niedermayer.cc> <20240804205309.1978196-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/8] avcodec/parser: clear padding in combine frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7706926021182569955==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7706926021182569955== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kJlOB0td3EGXEEtS" Content-Disposition: inline --kJlOB0td3EGXEEtS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 05, 2024 at 02:02:07AM +0200, Kacper Michajlow wrote: > On Sun, 4 Aug 2024 at 22:53, Michael Niedermayer = wrote: > > > > Fixes: use-of-uninitialized-value > > Fixes: 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-51= 79190066872320 > > > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/parser.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/parser.c b/libavcodec/parser.c > > index af17ee9c156..426cc314fb0 100644 > > --- a/libavcodec/parser.c > > +++ b/libavcodec/parser.c > > @@ -236,6 +236,7 @@ int ff_combine_frame(ParseContext *pc, int next, > > } > > pc->buffer =3D new_buffer; > > memcpy(&pc->buffer[pc->index], *buf, *buf_size); > > + memset(&pc->buffer[pc->index + *buf_size], 0, AV_INPUT_BUFFER_= PADDING_SIZE); > > pc->index +=3D *buf_size; > > return -1; > > } > > -- > > 2.45.2 >=20 > We already had patch like that some time ago, > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240627004037.1336-2-k= asper93@gmail.com/ will apply yours, somehow i missed these thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange --kJlOB0td3EGXEEtS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrErXwAKCRBhHseHBAsP q3j4AJ9kadLPeCHEApRBzUtSvIRJYfpxTACfTcFEN6wpsjJkgBZNLOC/c7KDOMc= =XI+r -----END PGP SIGNATURE----- --kJlOB0td3EGXEEtS-- --===============7706926021182569955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7706926021182569955==--