From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/8] avcodec/parser: clear padding in combine frame
Date: Mon, 5 Aug 2024 21:43:27 +0200
Message-ID: <20240805194327.GF4991@pb2> (raw)
In-Reply-To: <CABPLASQnf9eCHVRiJWsRArUMhMN+oudChi_qoPkB_cL-o4PWvA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]
On Mon, Aug 05, 2024 at 02:02:07AM +0200, Kacper Michajlow wrote:
> On Sun, 4 Aug 2024 at 22:53, Michael Niedermayer <michael@niedermayer.cc> wrote:
> >
> > Fixes: use-of-uninitialized-value
> > Fixes: 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5179190066872320
> >
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavcodec/parser.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/parser.c b/libavcodec/parser.c
> > index af17ee9c156..426cc314fb0 100644
> > --- a/libavcodec/parser.c
> > +++ b/libavcodec/parser.c
> > @@ -236,6 +236,7 @@ int ff_combine_frame(ParseContext *pc, int next,
> > }
> > pc->buffer = new_buffer;
> > memcpy(&pc->buffer[pc->index], *buf, *buf_size);
> > + memset(&pc->buffer[pc->index + *buf_size], 0, AV_INPUT_BUFFER_PADDING_SIZE);
> > pc->index += *buf_size;
> > return -1;
> > }
> > --
> > 2.45.2
>
> We already had patch like that some time ago,
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240627004037.1336-2-kasper93@gmail.com/
will apply yours, somehow i missed these
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
What does censorship reveal? It reveals fear. -- Julian Assange
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-08-05 19:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 20:53 [FFmpeg-devel] [PATCH 1/8] avcodec/apac: Clean padding space Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 2/8] avformat/mpeg: Check an avio_read() for failure Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 3/8] avformat/img2dec: Clear padding data after EOF Michael Niedermayer
2024-08-05 0:10 ` Kacper Michajlow
2024-08-05 19:40 ` Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 4/8] avcodec/parser: clear padding in combine frame Michael Niedermayer
2024-08-05 0:02 ` Kacper Michajlow
2024-08-05 19:43 ` Michael Niedermayer [this message]
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 5/8] avcodec/shorten: clear padding Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 6/8] avcodec/vc1dec: Clear mb_type_base and ttblk_base Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 7/8] avcodec/aic: Clear slice_data Michael Niedermayer
2024-08-04 20:53 ` [FFmpeg-devel] [PATCH 8/8] avcodec/alsdec: clear last_acf_mantissa Michael Niedermayer
2024-08-14 15:10 ` [FFmpeg-devel] [PATCH 1/8] avcodec/apac: Clean padding space Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805194327.GF4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git