From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4975148556 for ; Mon, 5 Aug 2024 19:40:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44A2168C409; Mon, 5 Aug 2024 22:40:48 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6242268D737 for ; Mon, 5 Aug 2024 22:40:42 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 94C2240002 for ; Mon, 5 Aug 2024 19:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722886841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eJ+qx3L3j6vkXCej+x7CivPI9ZFtpHTRCw7OqgAFglg=; b=io76Df9o/irEKHY8mXMv3O8ExfKL+/xB8jyigm2qf6eps1pLpzsp/ypvOPS+8Yx+yEBHA7 M5yW0LMK559xQV1NjbwGSf4naCChaFzXi9b0k17BGLsnzxfZwj8Nxa7c3FrHfLUFZczTYS 8Crc52kcKJnuJz4zPHjZshOD9X/GIlWCs7Wbo59OCs3Yk8nbO9wLG855rzrNzjO9HbdrZ6 6m58c6o0xLk7xUjdMoT5+yRHDIXkomWgYlBmZSiFf8jsjOIDtYxhNzudlAugTfj3xrNXKU Nek19+UNgLQDmQVIK1E3hLIie8gGheJ1mnozc/57nQCkoHknlxHbZjtTnwILng== Date: Mon, 5 Aug 2024 21:40:40 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240805194040.GE4991@pb2> References: <20240804205309.1978196-1-michael@niedermayer.cc> <20240804205309.1978196-3-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/8] avformat/img2dec: Clear padding data after EOF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8297896131242690130==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8297896131242690130== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rT2J5DU38xRYJFcJ" Content-Disposition: inline --rT2J5DU38xRYJFcJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 05, 2024 at 02:10:18AM +0200, Kacper Michajlow wrote: > On Sun, 4 Aug 2024 at 23:01, Michael Niedermayer = wrote: > > > > Fixes: use-of-uninitialized-value > > Fixes: 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-51= 79190066872320 > > > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/img2dec.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > > index 20b1bc31f6a..3389fa818e9 100644 > > --- a/libavformat/img2dec.c > > +++ b/libavformat/img2dec.c > > @@ -563,6 +563,7 @@ int ff_img_read_packet(AVFormatContext *s1, AVPacke= t *pkt) > > } > > goto fail; > > } else { > > + memset(pkt->data + pkt->size, 0, AV_INPUT_BUFFER_PADDING_SIZE); > > s->img_count++; > > s->img_number++; > > s->pts++; > > -- > > 2.45.2 >=20 > I've also had this one > (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240627004037.1336-3-= kasper93@gmail.com/), > but probably it is better to do it only in the else branch here. So, > LGTM. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --rT2J5DU38xRYJFcJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZrEquAAKCRBhHseHBAsP q5UWAKCXIcSnqxgq+ekAQvw9JhurFYQbyQCeI32Zpbc5ilGiOINN5YWoIHoH/L4= =Uz4C -----END PGP SIGNATURE----- --rT2J5DU38xRYJFcJ-- --===============8297896131242690130== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8297896131242690130==--