From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D34D47FDD for ; Sun, 4 Aug 2024 16:31:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 325B668D866; Sun, 4 Aug 2024 19:31:15 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22C2A68D2F5 for ; Sun, 4 Aug 2024 19:31:09 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1722789068; bh=tb3XT3niYj1z3FZNSkeYi6BMA1Vck/tXUeiVzXrjelo=; h=Date:From:To:Subject:In-Reply-To:References:From; b=GK4KZyQWV+KRSG1edbAKRWLhmULMLOzRhytNY49VLMVUjVg5+t+mbyDYm+NWvnH9E 0aV/IcMbvGktdtBAZO6BQQic10BzFCTDoBfwy+JM6AH/eoCxfqmuIWRdtTKrrJ8Xel csdf1nzdwDeiTsTdS9Pn76UiSuXRYhqPPqZgKx4Y= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 745344099C for ; Sun, 4 Aug 2024 18:31:08 +0200 (CEST) Date: Sun, 4 Aug 2024 18:31:08 +0200 Message-ID: <20240804183108.GB7082@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: References: <20240728102527.17991-1-ffmpeg@haasn.xyz> <20240728102527.17991-21-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 21/22] avcodec/libsvtav1: raise strictness of missing DV error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 03 Aug 2024 20:08:26 +0200 Andreas Rheinhardt wrote: > Niklas Haas: > > From: Niklas Haas > > > > While this is technically a spec violation, the result is still > > decodable (and will look perfectly fine to clients ignoring Dolby Vision > > metadata). It will also only happen in garbage in, garbage out scenarios. > > --- > > libavcodec/libsvtav1.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > > index e7b12fb488..4c91750fbe 100644 > > --- a/libavcodec/libsvtav1.c > > +++ b/libavcodec/libsvtav1.c > > @@ -551,10 +551,10 @@ static int eb_send_frame(AVCodecContext *avctx, const AVFrame *frame) > > } else if (svt_enc->dovi.cfg.dv_profile) { > > av_log(avctx, AV_LOG_ERROR, "Dolby Vision enabled, but received frame " > > "without AV_FRAME_DATA_DOVI_METADATA\n"); > > - return AVERROR_INVALIDDATA; > > + if (avctx->strict_std_compliance >= FF_COMPLIANCE_STRICT) > > + return AVERROR_INVALIDDATA; > > } > > > > - > > svt_ret = svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr); > > if (svt_ret != EB_ErrorNone) > > return svt_print_error(avctx, svt_ret, "Error sending a frame to encoder"); > > Encoders are supposed to be picky and only produce spec-compliant output. Okay, I could either drop this commit or raise it to UNOFFICIAL. But it probably makes more sense to drop it, such files should be phased out if they exist anyway. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".