From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D79A4845A for ; Thu, 1 Aug 2024 21:46:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C56D768D933; Fri, 2 Aug 2024 00:46:43 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63FC568CF19 for ; Fri, 2 Aug 2024 00:46:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BDEA060002 for ; Thu, 1 Aug 2024 21:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722548796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XVoiuIMPVHjuEmZxDhVURS2GeYJzbvZjH4OhYG7ey+U=; b=Uz48HN6kWNChefhXLwt06mmhycxk3lo6VMk7fH/PSqkiZS0GPIFvJcewW7xu9CFQMFrSrd jyhOs+ot3B7rckEq53ajQxWhlxK2+sSWdgE3izXz7i5bNRNLccfxs93ZuPtmgE9ZPyINsj ARv5wdgr8FBQxCIBVrLuaxboEWMdn67OzmHU3Sk1PJ9KgIcyO7s+2e2WjJVB3gWCYHtYAu DBCnyQhsdDh4M8I3Cv0Gs1XpRHi45vO9HfVlXedecMkmdjB895auKJTRj/rpbLn+6LM9y1 aygNMR6dFyaqXWgWfJ06K2j50NdgrOOsO2y3Jus//1knJ2gvd2PRY4g5If0WNA== Date: Thu, 1 Aug 2024 23:46:35 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240801214635.GB4991@pb2> References: <20240727043054.213199-1-aimingoff@pc.nifty.jp> <20240727043054.213199-2-aimingoff@pc.nifty.jp> <2cacbafe-202d-487d-8f08-63e78f4ed664@pc.nifty.jp> <20240728092619.GN4991@pb2> <259d3e34-3fbc-4e5d-8efe-33595e031538@pc.nifty.jp> <20240730204405.GO4991@pb2> <36491074-c885-4647-b3a8-d97a78092b9b@pc.nifty.jp> MIME-Version: 1.0 In-Reply-To: <36491074-c885-4647-b3a8-d97a78092b9b@pc.nifty.jp> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] lavfi/vf_gopromax_opencl: add GoPor Max 360 video filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5766081895190045428==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5766081895190045428== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rGFapJQksCwzvIuF" Content-Disposition: inline --rGFapJQksCwzvIuF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 31, 2024 at 11:45:29PM +0900, TADANO Tokumei wrote: > On 2024/07/31 5:44, Michael Niedermayer wrote: > > On Mon, Jul 29, 2024 at 01:30:34AM +0900, TADANO Tokumei wrote: > > > On 2024/07/28 18:26, Michael Niedermayer wrote: > > > > On Sun, Jul 28, 2024 at 01:42:09AM +0900, TADANO Tokumei wrote: > > > > >=20 > > > > > On 2024/07/27 13:30, TADANO Tokumei wrote: > > > > > > Add an OpenCL filter for filtering GoPro Max native .360 files > > > > > > into standard equirectangular or youtube equiangular cubemap (e= ac) > > > > > > projection. > > > > > >=20 > > > > > > The .360 file contains separated two video streams. > > > > > > This filter combine two streams into single stream with standard > > > > > > format. > > > > > > --- > > > > > > doc/filters.texi | 78 +++++++ > > > > > > libavfilter/Makefile | 2 + > > > > > > libavfilter/allfilters.c | 1 + > > > > > > libavfilter/opencl/gopromax.cl | 280 ++++++++++++++++++++= ++++ > > > > > > libavfilter/opencl_source.h | 1 + > > > > > > libavfilter/vf_gopromax_opencl.c | 351 ++++++++++++++++++++= +++++++++++ > > > > > > 6 files changed, 713 insertions(+) > > > > > > create mode 100644 libavfilter/opencl/gopromax.cl > > > > > > create mode 100644 libavfilter/vf_gopromax_opencl.c > > > > >=20 > > > > > The patchwork failed, but it was caused by opencl.c (not by this = patch): > > > > >=20 > > > > > In file included from ./libavutil/common.h:48:0, > > > > > from ./libavutil/avutil.h:301, > > > > > from ./libavutil/opt.h:31, > > > > > from libavdevice/sdl2.c:31: > > > > > ./config.h:335:0: warning: 'HAVE_PTHREAD_SETNAME_NP' redefined > > > > > #define HAVE_PTHREAD_SETNAME_NP 0 > > > > > In file included from /usr/include/SDL2/SDL_stdinc.h:31:0, > > > > > from /usr/include/SDL2/SDL_main.h:25, > > > > > from /usr/include/SDL2/SDL.h:32, > > > > > from libavdevice/sdl2.c:26: > > > > > /usr/include/SDL2/SDL_config.h:186:0: note: this is the location = of the previous definition > > > > > #define HAVE_PTHREAD_SETNAME_NP 1 > > > > > In file included from libavfilter/opencl.h:31:0, > > > > > from libavfilter/opencl.c:26: > > > > > ./libavutil/hwcontext_opencl.h:25:10: fatal error: CL/cl.h: No su= ch file or directory > > > > > #include > > > > > ^~~~~~~~~ > > > > > compilation terminated. > > > > > make: *** [libavfilter/opencl.o] Error 1 > > > >=20 > > > > with this patch it fails here on ubuntu: > > > > /usr/bin/ld: libavfilter/libavfilter.a(opencl.o): undefined referen= ce to symbol 'clBuildProgram@@OPENCL_1.0' > > > > /usr/bin/ld: /usr/local/cuda/targets/x86_64-linux/lib/libOpenCL.so.= 1: error adding symbols: DSO missing from command line > > > >=20 > > > > thx > > >=20 > > > I tested on Ubuntu 22.04, and it works fine. > >=20 > > My failure was on a 20.04 > >=20 > > thx >=20 > Did you try v3 patch? i only saw v3 after i tested v2 v3 no longer fails thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --rGFapJQksCwzvIuF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZqwCOwAKCRBhHseHBAsP q5MCAJ9QDWE/oWrBp8cafMQIlgQqMiuyQQCeMppAy+A0LOtPTiGp263ssyeXwX8= =g9CX -----END PGP SIGNATURE----- --rGFapJQksCwzvIuF-- --===============5766081895190045428== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5766081895190045428==--