Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for multiple decryption keys
Date: Thu, 1 Aug 2024 19:30:51 +0200
Message-ID: <20240801173051.GA4991@pb2> (raw)
In-Reply-To: <CABPLAST66mQc2GwruLfj1LFWtcKKjXVxY9SApxDWefEG_X9-Kg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1793 bytes --]

On Thu, Aug 01, 2024 at 02:53:29AM +0200, Kacper Michajlow wrote:
> On Mon, 13 Nov 2023 at 09:40, Adrien Guinet <adrien@guinet.me> wrote:
> >
> > This commit introduces new options to support more than one decryption
> > keys:
> > * add a decryption_keys option to MOV, that supports a dictionnary of
> >   KID=>key (in hex), using AV_OPT_TYPE_DICT
> > * add the corresponding cenc_decryption_keys option to DASH
> > ---
> >  doc/demuxers.texi                          | 12 +++-
> >  libavformat/dashdec.c                      |  6 +-
> >  libavformat/isom.h                         |  5 +-
> >  libavformat/mov.c                          | 80 ++++++++++++++++++----
> >  tests/fate/mov.mak                         | 12 ++++
> >  tests/ref/fate/mov-3elist-encrypted-kid    | 57 +++++++++++++++
> >  tests/ref/fate/mov-frag-encrypted-kid      | 57 +++++++++++++++
> >  tests/ref/fate/mov-tenc-only-encrypted-kid | 57 +++++++++++++++
> >  8 files changed, 269 insertions(+), 17 deletions(-)
> >  create mode 100644 tests/ref/fate/mov-3elist-encrypted-kid
> >  create mode 100644 tests/ref/fate/mov-frag-encrypted-kid
> >  create mode 100644 tests/ref/fate/mov-tenc-only-encrypted-kid
[...]
>
> Works as advertised, thanks.

> Hope it can be merged one day.

didnt look at the patch but i agree
it seems this patch was missed

But this reminds me, we seem not to have anyone listed for the encrypted
support in MOV & co in MAINTAINERs
can  someone of the people, who worked on this code
review it please!

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-08-01 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13  8:40 Adrien Guinet
2024-08-01  0:53 ` Kacper Michajlow
2024-08-01 17:30   ` Michael Niedermayer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-11-12 17:06 Adrien Guinet
2023-11-12 17:18 ` Michael Niedermayer
2023-11-13  8:35   ` Adrien Guinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240801173051.GA4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git