From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5FA714C665 for ; Wed, 31 Jul 2024 12:14:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C03D68D73F; Wed, 31 Jul 2024 15:14:10 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F156168D65B for ; Wed, 31 Jul 2024 15:14:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1722428043; bh=fx6O/gNfShDtqrTIHqAWjYb2LmaNsJAG9Mj0Q4iDMk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aasGoq8XjUHW8AFZ0TjkSqE5M/DsxuyEiEE6enQhBfkios05CjO2P9UIyVJX1fBh6 7tjg//NAM8+XEMYx4kTnRjHd/a5jhBbgfTosttK/+OhPC5FNguA+7BSI6iZLuxmhIU PMV7g/eityAKQAk4a72W249/N7IZPsd6xGQuub1M= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id F0A0042B25; Wed, 31 Jul 2024 14:14:02 +0200 (CEST) Date: Wed, 31 Jul 2024 14:14:02 +0200 Message-ID: <20240731141402.GB46515@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240728102527.17991-1-ffmpeg@haasn.xyz> References: <20240728102527.17991-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH 01/22] avutil/dovi_meta: document static vs dynamic ext blocks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 28 Jul 2024 12:25:06 +0200 Niklas Haas wrote: > From: Niklas Haas > > --- > libavutil/dovi_meta.h | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/libavutil/dovi_meta.h b/libavutil/dovi_meta.h > index c942d0e133..5e8a1e43d7 100644 > --- a/libavutil/dovi_meta.h > +++ b/libavutil/dovi_meta.h > @@ -301,26 +301,28 @@ typedef struct AVDOVIDmLevel255 { > } AVDOVIDmLevel255; > > /** > - * Dolby Vision metadata extension block. > + * Dolby Vision metadata extension block. Dynamic extension blocks may change > + * from frame to frame, while static blocks are constant throughout the entire > + * sequence. > * > * @note sizeof(AVDOVIDmData) is not part of the public API. > */ > typedef struct AVDOVIDmData { > uint8_t level; /* [1, 255] */ > union { > - AVDOVIDmLevel1 l1; > - AVDOVIDmLevel2 l2; /* may appear multiple times */ > - AVDOVIDmLevel3 l3; > - AVDOVIDmLevel4 l4; > - AVDOVIDmLevel5 l5; > - AVDOVIDmLevel6 l6; > + AVDOVIDmLevel1 l1; /* dynamic */ > + AVDOVIDmLevel2 l2; /* dynamic, may appear multiple times */ > + AVDOVIDmLevel3 l3; /* dynamic */ > + AVDOVIDmLevel4 l4; /* dynamic */ > + AVDOVIDmLevel5 l5; /* dynamic */ > + AVDOVIDmLevel6 l6; /* static */ > /* level 7 is currently unused */ > - AVDOVIDmLevel8 l8; /* may appear multiple times */ > - AVDOVIDmLevel9 l9; > - AVDOVIDmLevel10 l10; /* may appear multiple times */ > - AVDOVIDmLevel11 l11; > - AVDOVIDmLevel254 l254; > - AVDOVIDmLevel255 l255; > + AVDOVIDmLevel8 l8; /* dynamic, may appear multiple times */ > + AVDOVIDmLevel9 l9; /* dynamic */ > + AVDOVIDmLevel10 l10; /* static, may appear multiple times */ > + AVDOVIDmLevel11 l11; /* dynamic */ > + AVDOVIDmLevel254 l254; /* static */ > + AVDOVIDmLevel255 l255; /* static */ > }; > } AVDOVIDmData; > > -- > 2.45.2 > Ping for review. Code passes DV bitstream validator, so will consider merging soon if there are no objections. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".