From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3868A4C5A2 for ; Tue, 30 Jul 2024 13:12:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F3F2C68D79B; Tue, 30 Jul 2024 16:12:17 +0300 (EEST) Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C64468D76C for ; Tue, 30 Jul 2024 16:12:12 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=s1; h=Message-ID:Date:Subject:Cc:To:From:Sender; bh=NuBf44Qj6+fLFCbrpNwxZt4rC0co9hHegINM0tGdX1A=; b=I0K59JrnYIf63u3UpthbnCFWlO W56bwAiUF4huo7qg+rvEXsmETgHOVhgnGAhPN2Gx8CQ82yW381dog3IOBCYJu0bZ8Rxg9Eafsv8KY +QPM15CgrfZg8vC/SdMSBLJlQnLQ08aI7ibQOmj0DxODQ0TAFVhTyzvD34FhQnQhQxA/vcZoDxwnP dYzGG9Hz31ZVx8890wxxo+2e/ckylWTpJCQeYYIwAhx4lfS3QJoF8iuUjwwXSn9vChOmXZvDo4NJr l4dmLhR0+aoKOhXgPWF6fo92P/HAN6TpfxnJGBwrpliM1QI/9o4ibNJpQxqM7IOoj7fdXMhHKkgYT cQZ8UYnw==; Received: from cw141ip115.vpn.codeweavers.com ([10.69.141.115] helo=localhost.localdomain) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sYme9-0055F4-39; Tue, 30 Jul 2024 08:12:10 -0500 From: Giovanni Mascellani To: ffmpeg-devel@ffmpeg.org Date: Tue, 30 Jul 2024 15:11:49 +0200 Message-ID: <20240730131149.210571-3-gmascellani@codeweavers.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730131149.210571-1-gmascellani@codeweavers.com> References: <20240730131149.210571-1-gmascellani@codeweavers.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/evc_ps: Interpret a degenerate SAR as 1/1. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Giovanni Mascellani Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The specification doesn't say what should happen in this case. Other implementations (e.g., Microsoft's Media Foundations) seem to interpret this as 1/1. Signed-off-by: Giovanni Mascellani --- libavcodec/evc_ps.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c index 637572d324..6c871e965e 100644 --- a/libavcodec/evc_ps.c +++ b/libavcodec/evc_ps.c @@ -87,6 +87,10 @@ static int vui_parameters(GetBitContext *gb, VUIParameters *vui) if (vui->aspect_ratio_idc == EXTENDED_SAR) { vui->sar_width = get_bits(gb, 16); vui->sar_height = get_bits(gb, 16); + if (vui->sar_width == 0 || vui->sar_height == 0) { + vui->sar_width = 1; + vui->sar_height = 1; + } } } vui->overscan_info_present_flag = get_bits(gb, 1); -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".