From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 85545483B8 for ; Tue, 30 Jul 2024 13:12:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AC1B468D78D; Tue, 30 Jul 2024 16:12:16 +0300 (EEST) Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 666D668D733 for ; Tue, 30 Jul 2024 16:12:09 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=s1; h=Message-ID:Date:Subject:Cc:To:From:Sender; bh=ECaq/VfQ/BkDDt2K+JovGpufLRCWahkcvNPNDus5ckE=; b=Lav3Jhl6yY34Z5O2kKxcm5EtsJ io9PJ/tlsVCZU7qFeVFNm3WldCIxhZKy2G00rSau26kkmTHJGa6YEU7GZORyhqKm7cY3uwzhuyhlZ 1O+3Q7KXbChumaS8oL8kTp0eCUKPmsvQegg8oolBkXgmAJxI7JQpmsk27C88GPhy1XsyNScEl+sYK z18rsPp9JBlQeCl6Q3Mk01nz2UhwxcC6UJL0U37UIuOaId7/fAAhjpDhpyqcPOln29q7V+76W8k21 mZzhl/e0D4g+ElQR9cOeFloUPcL+AXtInP0FFfwhgvgrsOR6Z7GRpEqMjiGwkhLUP8Nd/HUdcHz5h 30089jTA==; Received: from cw141ip115.vpn.codeweavers.com ([10.69.141.115] helo=localhost.localdomain) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sYme7-0055F4-06; Tue, 30 Jul 2024 08:12:08 -0500 From: Giovanni Mascellani To: ffmpeg-devel@ffmpeg.org Date: Tue, 30 Jul 2024 15:11:48 +0200 Message-ID: <20240730131149.210571-2-gmascellani@codeweavers.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240730131149.210571-1-gmascellani@codeweavers.com> References: <20240730131149.210571-1-gmascellani@codeweavers.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/h2645_vui: Interpret a degenerate SAR as 1/1. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Giovanni Mascellani Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The specification doesn't say what should happen in this case. Other implementations (e.g., Microsoft's Media Foundations) seem to interpret this as 1/1. Signed-off-by: Giovanni Mascellani --- libavcodec/h2645_vui.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/h2645_vui.c b/libavcodec/h2645_vui.c index e5c7bf46f9..a9c0dbbef9 100644 --- a/libavcodec/h2645_vui.c +++ b/libavcodec/h2645_vui.c @@ -46,6 +46,10 @@ void ff_h2645_decode_common_vui_params(GetBitContext *gb, H2645VUI *vui, void *l else if (vui->aspect_ratio_idc == EXTENDED_SAR) { vui->sar.num = get_bits(gb, 16); vui->sar.den = get_bits(gb, 16); + if (vui->sar.num == 0 || vui->sar.den == 0) { + vui->sar.num = 1; + vui->sar.den = 1; + } } else av_log(logctx, AV_LOG_WARNING, "Unknown SAR index: %u.\n", vui->aspect_ratio_idc); -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".