From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3932A4C521 for ; Sun, 28 Jul 2024 20:21:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5525168D8F8; Sun, 28 Jul 2024 23:21:05 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 57F1568D8AF for ; Sun, 28 Jul 2024 23:20:56 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 99C0FFF805 for ; Sun, 28 Jul 2024 20:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1722198055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n+6YsVsXeLNX5fUQPDuCGuQkwHpcpSu7QIOTQCqThGs=; b=O9EMLDUS7fJY/jrln+aLT0fKW8HhmhoTSiROVylfJ+3sqMXeY0koAsWTNhcya3r+k46cpv zuEMTQg0AfozYkgJJkPGTdYCBP4riBGBOqIz/OFiETRGaKF7BvAweYl0Y/baOkuiD+d7jQ nt3+Y5DQlnr08xqiBl8kyUAJHIMzDJJsq3ZXnSWvVEqvXoDKdcF0InZ27zcJwAPxj/gSv7 VaolY0hIyWvDbpRlhKiGOJsktO4fHSWMZ9QLSJp7FMzMHK18bLAo3/c+m8FQuqpCOE2/86 SN6DGhNT9N+1f56Aa5wGVdZbdC/SnLZqsoonn/ksVoHQpYD1AsKBdQ0+BTVirA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 28 Jul 2024 22:20:53 +0200 Message-ID: <20240728202053.3120590-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240728202053.3120590-1-michael@niedermayer.cc> References: <20240728202053.3120590-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/2] avformat/matroskadec: Check desc_bytes so bits fit in 64bit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Likely a tighter check can be done Fixes: signed integer overflow: 3305606804154370442 * 8 cannot be represented in type 'long' Fixes: 70449/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-4771166007918592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index aa28a37da4c..175d6a3ef61 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -4633,7 +4633,7 @@ static int64_t webm_dash_manifest_compute_bandwidth(AVFormatContext *s, int64_t int64_t desc_bytes = desc_end.end_offset - desc_beg.start_offset; int64_t desc_ns = desc_end.end_time_ns - desc_beg.start_time_ns; double desc_sec, calc_bits_per_second, percent, mod_bits_per_second; - if (desc_bytes <= 0) + if (desc_bytes <= 0 || desc_bytes > INT64_MAX/8) return -1; desc_sec = desc_ns / nano_seconds_per_second; -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".