From: Marth64 <marth64@proxyid.net> To: ffmpeg-devel@ffmpeg.org Cc: Marth64 <marth64@proxyid.net> Subject: [FFmpeg-devel] [PATCH 6/7] avformat/dvdvideodec: Simplify/clarify logs, comments, and class name Date: Sun, 28 Jul 2024 02:34:44 -0500 Message-ID: <20240728073445.725161-7-marth64@proxyid.net> (raw) In-Reply-To: <20240728073445.725161-1-marth64@proxyid.net> Signed-off-by: Marth64 <marth64@proxyid.net> --- libavformat/dvdvideodec.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index afc7836038..04c5cbea8e 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -21,7 +21,7 @@ /* * See doc/demuxers.texi for a high-level overview. * - * The tactical approach is as follows: + * The tactical approach for title playback is as follows: * 1) Open the volume with dvdread * 2) Analyze the user-requested title and PGC coordinates in the IFO structures * 3) Request playback at the coordinates and chosen angle with dvdnav @@ -565,8 +565,8 @@ static int dvdvideo_play_open(AVFormatContext *s, DVDVideoPlaybackState *state) } if (c->opt_trim && !dvdvideo_is_pgc_promising(s, pgc)) { - av_log(s, AV_LOG_ERROR, "Title %d, PGC %d looks empty (may consist of padding cells), " - "if you want to try anyway, disable the -trim option\n", + av_log(s, AV_LOG_ERROR, "Title %d, PGC %d looks empty (may consist of padding cells); " + "if you want to try anyway, disable the trim option\n", c->opt_title, state->pgcn); return AVERROR_INVALIDDATA; @@ -757,7 +757,7 @@ static int dvdvideo_play_next_ps_block(AVFormatContext *s, DVDVideoPlaybackState if (!state->in_ps) { if (c->opt_trim && !dvdvideo_is_cell_promising(s, state->pgc, state->celln)) { - av_log(s, AV_LOG_INFO, "Skipping padding cell #%d\n", state->celln); + av_log(s, AV_LOG_INFO, "Trimming padding cell #%d\n", state->celln); i = 0; continue; @@ -1175,8 +1175,7 @@ static int dvdvideo_audio_stream_analyze(AVFormatContext *s, audio_attr_t audio_ if (audio_attr.application_mode == 1) { entry->disposition |= AV_DISPOSITION_KARAOKE; - av_log(s, AV_LOG_WARNING, "Extended karaoke metadata is not supported at this time " - "(stream id=%d)\n", startcode); + av_log(s, AV_LOG_WARNING, "Karaoke extensions not supported (stream id=%d)\n", startcode); } if (audio_attr.code_extension == 2) @@ -1770,7 +1769,7 @@ static const AVOption dvdvideo_options[] = { }; static const AVClass dvdvideo_class = { - .class_name = "DVD-Video demuxer", + .class_name = "dvdvideo", .item_name = av_default_item_name, .option = dvdvideo_options, .version = LIBAVUTIL_VERSION_INT -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-28 7:36 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-07-28 7:34 [FFmpeg-devel] [PATCH 0/7] avformat/dvdvideodec: Bug fixes, seeking support, and menu chapters Marth64 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 1/7] avformat/dvdvideodec: Fix racy PTS calculation and frame drops Marth64 2024-07-28 15:34 ` Marth64 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking Marth64 2024-07-28 15:20 ` Sean McGovern 2024-07-28 15:30 ` Marth64 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 3/7] avformat/dvdvideodec: Combine libdvdread and libdvdnav log callbacks Marth64 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 4/7] avformat/dvdvideodec: Chapter markers and trimming for menus Marth64 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 5/7] avformat/dvdvideodec: Remove unused headers Marth64 2024-07-28 7:34 ` Marth64 [this message] 2024-07-28 7:34 ` [FFmpeg-devel] [PATCH 7/7] doc/demuxers: update dvdvideodec documentation Marth64
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240728073445.725161-7-marth64@proxyid.net \ --to=marth64@proxyid.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git