Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 1/1] lavc/ac3dsp: fix R-V CPU requirements
Date: Sat, 27 Jul 2024 15:51:52 +0300
Message-ID: <20240727125152.55694-1-remi@remlab.net> (raw)

It probably will not matter on any real hardware, but the Zbb optimisations
do not require Zba. And then, we need HAVE_RVV to build the RVV stuff.
---
 libavcodec/riscv/ac3dsp_init.c | 36 ++++++++++++++++++++--------------
 1 file changed, 21 insertions(+), 15 deletions(-)

diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3dsp_init.c
index f66b6cac57..24b3881854 100644
--- a/libavcodec/riscv/ac3dsp_init.c
+++ b/libavcodec/riscv/ac3dsp_init.c
@@ -41,26 +41,32 @@ av_cold void ff_ac3dsp_init_riscv(AC3DSPContext *c)
 #if HAVE_RV
     int flags = av_get_cpu_flags();
 
-    if (flags & AV_CPU_FLAG_RVB_BASIC)
+    if (flags & AV_CPU_FLAG_RVB_BASIC) {
         c->ac3_exponent_min = ff_ac3_exponent_min_rvb;
-    if (flags & AV_CPU_FLAG_RVV_I32)
+        c->extract_exponents = ff_extract_exponents_rvb;
+    }
+
+# if HAVE_RVV
+    if (flags & AV_CPU_FLAG_RVV_I32) {
         c->ac3_exponent_min = ff_ac3_exponent_min_rvv;
 
-    if (flags & AV_CPU_FLAG_RVB_ADDR) {
-        if (flags & AV_CPU_FLAG_RVB_BASIC)
-            c->extract_exponents = ff_extract_exponents_rvb;
-# if HAVE_RV_ZVBB
-        if (flags & AV_CPU_FLAG_RV_ZVBB)
-            c->extract_exponents = ff_extract_exponents_rvvb;
+        if (flags & AV_CPU_FLAG_RVB) {
+#  if HAVE_RV_ZVBB
+            if (flags & AV_CPU_FLAG_RV_ZVBB)
+                c->extract_exponents = ff_extract_exponents_rvvb;
+#  endif
+            if (flags & AV_CPU_FLAG_RVV_F32) {
+                c->float_to_fixed24 = ff_float_to_fixed24_rvv;
+                c->sum_square_butterfly_float =
+                    ff_sum_square_butterfly_float_rvv;
+            }
+#  if __riscv_xlen >= 64
+            if (flags & AV_CPU_FLAG_RVV_I64)
+                c->sum_square_butterfly_int32 =
+                    ff_sum_square_butterfly_int32_rvv;
+#  endif
 # endif
-        if (flags & AV_CPU_FLAG_RVV_F32) {
-            c->float_to_fixed24 = ff_float_to_fixed24_rvv;
-            c->sum_square_butterfly_float = ff_sum_square_butterfly_float_rvv;
         }
-# if __riscv_xlen >= 64
-        if (flags & AV_CPU_FLAG_RVV_I64)
-            c->sum_square_butterfly_int32 = ff_sum_square_butterfly_int32_rvv;
-# endif
     }
 #endif
 }
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2024-07-27 12:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240727125152.55694-1-remi@remlab.net \
    --to=remi@remlab.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git