From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6C225471D1 for ; Thu, 25 Jul 2024 08:25:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D321368D3C9; Thu, 25 Jul 2024 11:25:12 +0300 (EEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B311868CC49 for ; Thu, 25 Jul 2024 11:25:06 +0300 (EEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ef32fea28dso7069201fa.2 for ; Thu, 25 Jul 2024 01:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1721895905; x=1722500705; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4VZOKz/qAfeQ2SRW99SbEum9FQZwFXh1ATJo6nbJZ9Q=; b=z3GOrckx/FqLSzhr0ecT6lOMlSJaL2zhQTEaqXhTRbizsprTJ75dtMY/k63crmmaw9 CWGoMaMWAavjAzNxg3OhHKnwdoABozncGZYDdMWPsqulQm8FVNpkSoJ0EWVY3PGRrO06 HYyQZ9HnDEbJ9Z/mnndxi/XFnZaRVKC0D0ELywLGDJEBJ42AS+fHm5nDiohjFIJoMUyI A6jBbupK/zPI9f08hxcRtUVFLl6zpFgx7+NHLJPpAWoMnJLa1z63jYar1nYjxpvbkaoX VnP9ptNRTBDBf2qdRJDN5P478il9iYik/gWcR+AJ8d2z2N7SS7TrJB2gR8oVtm462wS4 l2Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721895905; x=1722500705; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4VZOKz/qAfeQ2SRW99SbEum9FQZwFXh1ATJo6nbJZ9Q=; b=blzZLTw7GpVFRD2fZRA2uIBpEFxxlMKmnJeFU1wYzq6Bnjzswcn4Xeth1npSeF9D4x iXXophc5nxWGzAw8Ze3kwXRNHqF8mVb2W2CDNoKURsGGL+jEIWTbriOpGQ6Ncw6kTg6J 8fmjgcp1YF4VATnPoCB8Xv7DsbINBtG4x88xRCqciacelktWfJsLzrfjxs5paJoK3JxL VqiRRAUvJOg+upk9bHeqwfGr9A3NZCyH2cAp7FliXgAonKx8T4I9MhvSvQXp7yHjv9F+ 4C7a5DPY191UgRpyInOH3mbK8s2eII4oG4ooUMIv1b1LsR3nktaQiKSH2VVL6JFqIvoG jEIg== X-Gm-Message-State: AOJu0YzBEyqXLXsWArW2m+vpHpFdpUyFCGATKOr88CLovAdDPu1r8uK2 WrfmWEgL25JBKapgv5gmPqyuTMdQAi+VuFx36TUE8luo6u2mwEovAfhgVghgpry00xS+NPTb9DX AoQ== X-Google-Smtp-Source: AGHT+IGs8P/pBqb+vBCi/EYqiqLNf9DqOncZlwL0XvioS14rsIt61G7EcW5w0D8m9A+Wbq02CW5B2A== X-Received: by 2002:a2e:be0c:0:b0:2f0:3cff:30ce with SMTP id 38308e7fff4ca-2f03cff31ccmr11392871fa.0.1721895905273; Thu, 25 Jul 2024 01:25:05 -0700 (PDT) Received: from localhost (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f03cf56483sm1304671fa.66.2024.07.25.01.25.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 01:25:04 -0700 (PDT) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Jul 2024 11:25:04 +0300 Message-Id: <20240725082504.883576-1-martin@martin.st> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [GASPP PATCH] Omit the "-c" argument from the preprocessing command X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: A command like "cc -c -E" is tautological; the -c is ignored, when we explicitly specify that we want to preprocess only. Since https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353cf5600e9c and https://github.com/llvm/llvm-project/pull/98607, Clang now warns about the unused "-c" argument in this case. We already did omit the "-c" argument when preprocessing (with cl.exe) for armasm, but do this for other cases as well. --- gas-preprocessor.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 19b0131..aa3abc0 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -155,6 +155,8 @@ while ($index < $#preprocess_c_cmd) { $index++; } +@preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd; + my $tempfile; if ($as_type ne "armasm") { @gcc_cmd = map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd; @@ -163,7 +165,6 @@ if ($as_type ne "armasm") { # Clang warns about unused -D parameters when invoked with "-x assembler". @gcc_cmd = grep ! /^-D/, @gcc_cmd; } else { - @preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd; @preprocess_c_cmd = grep ! /^-m/, @preprocess_c_cmd; @preprocess_c_cmd = grep ! /^-G/, @preprocess_c_cmd; -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".