From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 03B674C2CB for ; Wed, 24 Jul 2024 19:01:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7005968D6B8; Wed, 24 Jul 2024 22:01:35 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 28D8168D076 for ; Wed, 24 Jul 2024 22:01:29 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9772660004 for ; Wed, 24 Jul 2024 19:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721847688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b7xH35fdYw5H4gw4Yz76naxD+elcbdxdPGnEOh7xcbs=; b=gilztzwC7Wocb+RjCDRSpuvvcAWKMkJXzXoAuUcEdr9d6wiRil0l6J1vrVPDyh9PG0CfUU oGeCWUSqJ0uVWLTwphl7Ncr3/8Hthp3AbfqHEboBWJfI7ZNbh+8z9VSf52D53MsmqOJIu6 oNWjVmGMXMrfgZY4JDDrCz39CZL99XulGJsmy5jaqRcqE0hUhF879xptnnL/bUxBxjFFFD zC2whA/wE8GUA57oDa44xhJW4yT2wMrFWaHV+48WIPv18KhCboZ+oLTtFt91pD9ES6L/Bg pGFWBUB+WDJ7zpqP8u7rB3vZcQ6Rkp2j6re1FHjUFF/H/PMi6YKHQCAII1uU6w== Date: Wed, 24 Jul 2024 21:01:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240724190127.GR4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-7-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240716171155.31838-7-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 07/39] lavc/ffv1: add a per-slice context X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5107087320104067510==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5107087320104067510== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h7puR0qIsdcfY/Vv" Content-Disposition: inline --h7puR0qIsdcfY/Vv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2024 at 07:11:22PM +0200, Anton Khirnov wrote: > FFV1 decoder and encoder currently use the same struct - FFV1Context - > both as codec private data and per-slice context. For this purpose > FFV1Context contains an array of pointers to per-slice FFV1Context > instances. >=20 > This pattern is highly confusing, as it is not clear which fields are > per-slice and which per-codec. >=20 > Address this by adding a new struct storing only per-slice data. Start > by moving slice_{x,y,width,height} to it. > --- > libavcodec/ffv1.c | 15 ++++++--- > libavcodec/ffv1.h | 13 +++++--- > libavcodec/ffv1dec.c | 76 ++++++++++++++++++++++++-------------------- > libavcodec/ffv1enc.c | 25 ++++++++------- > 4 files changed, 76 insertions(+), 53 deletions(-) LGTM thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott --h7puR0qIsdcfY/Vv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZqFPhwAKCRBhHseHBAsP q5XKAJ9ifMNHdCohiDvzAttiqM4g32mg6wCcCgfYJdMtyg+GwuL6KXskzkBqImE= =PoNI -----END PGP SIGNATURE----- --h7puR0qIsdcfY/Vv-- --===============5107087320104067510== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5107087320104067510==--