From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D22B4A202 for ; Tue, 23 Jul 2024 20:14:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6FC6B68D519; Tue, 23 Jul 2024 23:14:27 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3AD0B68D265 for ; Tue, 23 Jul 2024 23:14:21 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 99713240003 for ; Tue, 23 Jul 2024 20:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721765660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1u30okkoxVt+zi9NmiDj07BazKsoiomjzJkydTigaQ8=; b=HEpB7Y/g4QFbglhjAv2HvA001s6CDQlwzAZIeBFvzVfoivIEPl+psbnodlv7g5gO8Mqy88 d73Dg5x30ZTX3xTnuPh2SgZzBExc04pvUeO6iJEzz3LG0OOQcJD7abkCMDzP7vxQvADa3q +FI3pneE0TeV/OHN/V1sjIZItJ2PGAUyYo3UUlDawrPUGY/dzGnmm5pYZatf3gE/fhGsYB yqqcOTlaq5ovkxV6gh6BsZy61elhdVsnJPo7Rss/Em+jfhy0HCSmYrW5WFLsp9KS8WTPIG QFuqWWX7GQeoByP/9V9PSSbnQJB1XOC0GPfg+IuuYH8CWjCDIgxmpJKixUhXDw== Date: Tue, 23 Jul 2024 22:14:19 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240723201419.GD4991@pb2> References: <20240717205156.GT4991@pb2> <20240722094322.28916-1-anton@khirnov.net> <20240722094322.28916-2-anton@khirnov.net> <20240722211404.GU4991@pb2> <172171757878.21847.669877092691675989@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <172171757878.21847.669877092691675989@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2666017447576029568==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2666017447576029568== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e7t3zDdoAGSAyuyD" Content-Disposition: inline --e7t3zDdoAGSAyuyD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > There is no reason to delay it and this is a more natural place for > > > this code. > >=20 > > There is a reason. > > By doing it later the surrounding pixels are available and one could > > compute motion vectors from these surroundings and use all kinds of stu= ff > > from motion compensation and optical flow and all that. > >=20 > > someone, i dont remember exactly who, (maybe you remember?) > > said something about premature optimization is the root of all evil. > > Here that actually applies. Moving the code up thwarts write better > > error concealment. (and frankly we already have most of that EC code > > it would just need a cleanup to free it from the 16x16 limitation) >=20 > This is not an optimization though. >=20 > But okay, I am dropping both original patch 28 and these 3 new patches. > Are you ok with the rest of the series? The series looked mostly ok, is there somewhere i can take a quick look at the current set ? also i definitly want all bugfixes and speedups you did :) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --e7t3zDdoAGSAyuyD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZqAPFAAKCRBhHseHBAsP q+2WAJoDE+A03k19/ZtNmKAzpcPNCywC1wCeMOnyy+XMSzrH+RrkdPSHh/Y7SXI= =ECpr -----END PGP SIGNATURE----- --e7t3zDdoAGSAyuyD-- --===============2666017447576029568== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2666017447576029568==--