From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] lavc/vp8dsp: fix RV32 stack alignment
Date: Tue, 23 Jul 2024 18:49:07 +0300
Message-ID: <20240723154907.4212-1-remi@remlab.net> (raw)
SP must be a multiple of 16 bytes at all times on POSIX - even in leaf
functions - so that signal handlers have a properly aligned stack.
---
libavcodec/riscv/vp8dsp_rvv.S | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S
index e5d5a80bf8..f3b0af3116 100644
--- a/libavcodec/riscv/vp8dsp_rvv.S
+++ b/libavcodec/riscv/vp8dsp_rvv.S
@@ -469,14 +469,14 @@ endfunc
func ff_put_vp8_epel\len\()_h\hsize\()v\vsize\()_rvv, zve32x
lpad 0
#if __riscv_xlen == 64
- addi sp, sp, -48
+ addi sp, sp, -48
.irp n,0,1,2,3,4,5
- sd s\n, \n\()<<3(sp)
+ sd s\n, (\n * 8)(sp)
.endr
#else
- addi sp, sp, -24
+ addi sp, sp, -32
.irp n,0,1,2,3,4,5
- sw s\n, \n\()<<2(sp)
+ sw s\n, (\n * 4)(sp)
.endr
#endif
sub a2, a2, a3
@@ -518,14 +518,14 @@ func ff_put_vp8_epel\len\()_h\hsize\()v\vsize\()_rvv, zve32x
#if __riscv_xlen == 64
.irp n,0,1,2,3,4,5
- ld s\n, \n\()<<3(sp)
+ ld s\n, (\n * 8)(sp)
.endr
- addi sp, sp, 48
+ addi sp, sp, 48
#else
.irp n,0,1,2,3,4,5
- lw s\n, \n\()<<2(sp)
+ lw s\n, (\n * 4)(sp)
.endr
- addi sp, sp, 24
+ addi sp, sp, 32
#endif
ret
--
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2024-07-23 15:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723154907.4212-1-remi@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git