From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2B07D4AD90 for ; Mon, 22 Jul 2024 22:41:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F25B868D535; Tue, 23 Jul 2024 01:41:31 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22B1B68D2AC for ; Tue, 23 Jul 2024 01:41:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 04FA940002 for ; Mon, 22 Jul 2024 22:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721688084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2QeHV82/vCLtj+dV7IT7EybA2wbmqJUekRNYWutxKg8=; b=kEF5TUrJ81g9I/z8/OsMmdRq2u9LMnCODH+HRvuUD+7fjINbK5npLAShrqWO1ppQAwr91w Sw5uV6agCi6t82tPzd5jFPD0lTRWzjnQyAz8bxIrd5VGZaJjNDsnnX8gFBNjh3wh+E/iGq 0IA3S7jZT1COZdm3xNCXBG6oXZ4nkPu5WUt7ag03+bYADfyHoqR7/zNPcZI8ErBSVOKRkc nYfRMq8eUpjjbo/9ux2FX2zqmrWJ/y1OWU5Ga2Fk09hqOpfZ+Ic19BMW831brc3aaHe3jB PYP8SnXMYD3s0HsrCIJE8b3ozTXTtQb6ABP8g/osjYw0Y25tsJ8CUYGyQBeaPw== Date: Tue, 23 Jul 2024 00:41:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240722224123.GW4991@pb2> References: <20240711094937.696960-1-michael@niedermayer.cc> <172119886502.21847.9874785919727246540@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <172119886502.21847.9874785919727246540@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/avio: avio_tell() only errors if the context is NULL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6619625890917346492==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6619625890917346492== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U7uHw1LxqiwCht4z" Content-Disposition: inline --U7uHw1LxqiwCht4z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2024 at 08:47:45AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-11 11:49:37) > > Found by code review related to coverity > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/avio.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/avio.h b/libavformat/avio.h > > index ebf611187dc..3be91e4b8a7 100644 > > --- a/libavformat/avio.h > > +++ b/libavformat/avio.h > > @@ -489,7 +489,7 @@ int64_t avio_skip(AVIOContext *s, int64_t offset); > > =20 > > /** > > * ftell() equivalent for AVIOContext. > > - * @return position or AVERROR. > > + * @return position or AVERROR in case s is NULL. >=20 > It seems weird to document an invalid call. its mainly a reminder that this doesnt return AVERROR arbitrarily and thus doesnt need to be checked thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger. -- Epictetus --U7uHw1LxqiwCht4z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZp7gDwAKCRBhHseHBAsP q570AJ9MEHkKE/x9t0S22NiXicnHkDH+1ACfXiw5g9XC+C9XZ/Tj9LXPGhzmMmw= =tAwX -----END PGP SIGNATURE----- --U7uHw1LxqiwCht4z-- --===============6619625890917346492== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6619625890917346492==--