From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D7DD4C140 for ; Mon, 22 Jul 2024 21:14:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2097B68D6C3; Tue, 23 Jul 2024 00:14:12 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 479BB68C25D for ; Tue, 23 Jul 2024 00:14:06 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 804F6240003 for ; Mon, 22 Jul 2024 21:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721682845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UrPkJq9tPWDoUlpCSJod7p6fH2ijhlUAOaTL+IR8fqQ=; b=YQEnZsCNBwiqaAZykaz/zZiQxzW5i4e+AopxRiWLF1s7Ns8dnzB0QVe5/5UJ7Oxk3Qz+kh jCPtgW068jhq8m7q0EPxqyximp4CZy9QoWoTi4t2wc/oeOXhDZ8nRR9xkKnIGzitrrDoV9 I/XkPiDehiUZTz1Zq1FU+H41FLpdr47UmsO/oBz9Jb+oog41XQqN+eiTWy8JzwOvmvO3vF AZspEQgmHsHUbbTwlsMlhsOmXkpQ1HF4DbqGQwX0VHdhPXFRERBEtCt7KcE1CbErbRxu0u IY9Zpqq26XB2YDY9JccjLmJYJ4hYG1befcjyoaYvoBso7EWTA7kX0hqB+4IrPA== Date: Mon, 22 Jul 2024 23:14:04 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240722211404.GU4991@pb2> References: <20240717205156.GT4991@pb2> <20240722094322.28916-1-anton@khirnov.net> <20240722094322.28916-2-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240722094322.28916-2-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7239323893198328072==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7239323893198328072== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b4/McbcP8l1brYvY" Content-Disposition: inline --b4/McbcP8l1brYvY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > There is no reason to delay it and this is a more natural place for > this code. There is a reason. By doing it later the surrounding pixels are available and one could compute motion vectors from these surroundings and use all kinds of stuff =66rom motion compensation and optical flow and all that. someone, i dont remember exactly who, (maybe you remember?) said something about premature optimization is the root of all evil. Here that actually applies. Moving the code up thwarts write better error concealment. (and frankly we already have most of that EC code it would just need a cleanup to free it from the 16x16 limitation) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew .= =2E." --b4/McbcP8l1brYvY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZp7LmQAKCRBhHseHBAsP q1raAJ9eQzkF2DV5hdkenEstbPMPJ1u3WQCfZOtaKkFGefXT8l8yJoSNlWDT4Xc= =Eqel -----END PGP SIGNATURE----- --b4/McbcP8l1brYvY-- --===============7239323893198328072== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7239323893198328072==--