Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 7/8] lavu/riscv: align functions to 4 bytes
Date: Mon, 22 Jul 2024 23:13:49 +0300
Message-ID: <20240722201350.53382-1-remi@remlab.net> (raw)
In-Reply-To: <20240722193818.50824-1-remi@remlab.net>

Currently the start of the byte range for each function is aligned to
4 bytes. But this can lead to situations whence the function is preceded
by a 2-byte C.NOP at the aligned 4-byte boundary. Then the first actual
instruction and the function symbol are only aligned on 2 bytes.

This forcefully disables compression for the alignment and the symbol,
thus ensuring that there is no padding before the function.
---
 libavutil/riscv/asm.S | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S
index 37fd7d3b03..633c93d5fd 100644
--- a/libavutil/riscv/asm.S
+++ b/libavutil/riscv/asm.S
@@ -38,7 +38,6 @@
 
         .macro func sym, ext1=, ext2=
             .text
-            .align 2
 
             .option push
             .ifnb \ext1
@@ -51,7 +50,11 @@
             .global \sym
             .hidden \sym
             .type   \sym, %function
+            .option push
+            .option norvc
+            .align  2
             \sym:
+            .option pop
 
             .macro endfunc
                 .size   \sym, . - \sym
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-07-22 20:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 19:38 [FFmpeg-devel] [PATCH 1/6] lavu/riscv: assembly for zicfilp LPAD Rémi Denis-Courmont
2024-07-22 19:38 ` [FFmpeg-devel] [PATCH 2/6] lavu/riscv: add forward-edge CFI landing pads Rémi Denis-Courmont
2024-07-22 19:38 ` [FFmpeg-devel] [PATCH 3/6] lavc/riscv: " Rémi Denis-Courmont
2024-07-22 19:38 ` [FFmpeg-devel] [PATCH 4/6] lavfi/riscv: " Rémi Denis-Courmont
2024-07-22 19:38 ` [FFmpeg-devel] [PATCH 5/6] sws/riscv: " Rémi Denis-Courmont
2024-07-22 19:38 ` [FFmpeg-devel] [PATCH 6/6] checkasm/riscv: " Rémi Denis-Courmont
2024-07-22 20:13 ` Rémi Denis-Courmont [this message]
2024-07-22 20:13 ` [FFmpeg-devel] [PATCH 8/8] checkasm/riscv: align the " Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722201350.53382-1-remi@remlab.net \
    --to=remi@remlab.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git