Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/4] libavcodec/h2645_sei: export raw LCEVC metadata
Date: Sun, 21 Jul 2024 01:38:40 +0200
Message-ID: <20240720233840.GL4991@pb2> (raw)
In-Reply-To: <20240720124510.1689-2-jamrial@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1134 bytes --]

On Sat, Jul 20, 2024 at 09:45:08AM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/h2645_sei.c | 36 ++++++++++++++++++++++++++++++++++++
>  libavcodec/h2645_sei.h |  5 +++++
>  libavcodec/itut35.h    |  2 ++
>  3 files changed, 43 insertions(+)

I must be missing some patch as this doesnt build

libavcodec/h2645_sei.c: In function ‘h2645_sei_to_side_data’:
libavcodec/h2645_sei.c:698:63: error: ‘frame’ undeclared (first use in this function)
  698 |         AVFrameSideData *sd = av_frame_new_side_data_from_buf(frame, AV_FRAME_DATA_LCEVC, lcevc->info);
      |                                                               ^~~~~
libavcodec/h2645_sei.c:698:63: note: each undeclared identifier is reported only once for each function it appears in
CC	libavcodec/x86/flacencdsp_init.o
make: *** [ffbuild/common.mak:81: libavcodec/h2645_sei.o] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Elect your leaders based on what they did after the last election, not
based on what they say before an election.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-07-20 23:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20 12:45 [FFmpeg-devel] [PATCH 1/4] avutil/frame: add an LCEVC enhancement data payload side data type James Almer
2024-07-20 12:45 ` [FFmpeg-devel] [PATCH 2/4] libavcodec/h2645_sei: export raw LCEVC metadata James Almer
2024-07-20 23:38   ` Michael Niedermayer [this message]
2024-07-20 23:40     ` Gagan Sidhu via ffmpeg-devel
2024-07-21  0:17     ` James Almer
2024-07-21  0:18       ` Gagan Sidhu via ffmpeg-devel
2024-07-20 12:45 ` [FFmpeg-devel] [PATCH 3/4] avcodec: add LCEVC decoding support via LCEVCdec James Almer
2024-07-20 12:45 ` [FFmpeg-devel] [PATCH 4/4] avcodec/h264dec: add support for LCEVC enhancement James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240720233840.GL4991@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git