From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 03/11] avcodec/hevc/hevcdec: avoid signed shifts with lt_idx_sps
Date: Sat, 20 Jul 2024 02:52:33 +0200
Message-ID: <20240720005241.726089-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20240720005241.726089-1-michael@niedermayer.cc>
Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
Fixes: 70122/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5172200613675008
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/hevc/hevcdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c
index 0e4b26dad3b..7e0db79d16b 100644
--- a/libavcodec/hevc/hevcdec.c
+++ b/libavcodec/hevc/hevcdec.c
@@ -292,7 +292,7 @@ static int decode_lt_rps(const HEVCSPS *sps, LongTermRPS *rps,
lt_idx_sps = get_bits(gb, av_ceil_log2(sps->num_long_term_ref_pics_sps));
rps->poc[i] = sps->lt_ref_pic_poc_lsb_sps[lt_idx_sps];
- rps->used[i] = !!(sps->used_by_curr_pic_lt & (1 << lt_idx_sps));
+ rps->used[i] = !!(sps->used_by_curr_pic_lt & (1U << lt_idx_sps));
} else {
rps->poc[i] = get_bits(gb, sps->log2_max_poc_lsb);
rps->used[i] = get_bits1(gb);
--
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-20 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 0:52 [FFmpeg-devel] [PATCH 01/11] avcodec/alsdec: Clear shift_value Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 02/11] avcodec/proresdec: Consider negative bits left Michael Niedermayer
2024-07-20 0:52 ` Michael Niedermayer [this message]
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 04/11] avcodec/aac/aacdec_usac: Dont leave invalid max_sfb in the context Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 05/11] avcodec/aac/aacdec_lpd: Check kv indec Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 06/11] avcodec/vaapi_encode: Check hwctx Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 07/11] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter() Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 08/11] avcodec/osq: fix integer overflow when applying factor Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 09/11] avcodec/cfhdenc: Allocate more space Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 10/11] avcodec/cfhdenc: Height of 16 is not supported Michael Niedermayer
2024-07-20 0:52 ` [FFmpeg-devel] [PATCH 11/11] avcodec/hdrenc: Allocate more space Michael Niedermayer
2024-07-23 18:37 ` [FFmpeg-devel] [PATCH 01/11] avcodec/alsdec: Clear shift_value Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720005241.726089-3-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git