From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 28B134B8D6 for ; Sat, 20 Jul 2024 00:08:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D11AC68D982; Sat, 20 Jul 2024 03:08:36 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2770468D8B3 for ; Sat, 20 Jul 2024 03:08:30 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5F2751BF204 for ; Sat, 20 Jul 2024 00:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721434109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y0CcSrRnWThTGg20glFbn9JfDVZWeINI6SovoCVus74=; b=FURLVobIV+o4ASmj7NF99D4WAgMJUxzafwY79UXbS3QtM24VvKnpvKGRKK1ad9iCllXmdl j28BqAg3VFdp3mc+Lz9n1bkIVbLQxgB+JL+kokw9mFIx9l6LFuJJUikGYYzffqh5ENF5C5 p1r+hW+o6Ld1U5zjyh+tdxe/jWGRHf0dHF9alnFMqsYvfjvY+CkEnq1PVct3LCG9y+INFe Iv+PTzDmmQ1FJN3u9F72uM1xGD4AbQF8TIO5cEDTyk2x9hEVDwsXGJeFKKEZCAZec4IzH8 xMu4TkBrShlHW5ah0znzjwzaG/RM5ImFumpKe8vg0JVC+vxO1Ni/HJTR3Xansg== Date: Sat, 20 Jul 2024 02:08:28 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240720000828.GK4991@pb2> References: <20240715144825.3652038-1-michael@niedermayer.cc> <172119856184.21847.8183623909028998274@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <172119856184.21847.8183623909028998274@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0466206605382400620==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0466206605382400620== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pIgUhm2PSpi2KHBa" Content-Disposition: inline --pIgUhm2PSpi2KHBa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-07-15 16:48:25) [...] > > @@ -3155,8 +3156,11 @@ static int decode_slice(HEVCContext *s, const H2= 645NAL *nal, GetBitContext *gb) > > int ret; > > =20 > > ret =3D hls_slice_header(&s->sh, s, gb); > > - if (ret < 0) > > + if (ret < 0) { > > + //The code is not capable to rewind from an error, the state n= ow is inconsistant so we cannot use it on depandant slices > = ^ ^ > = e e > Also I'd drop everything before the comma, why mention rewinding that is > not implemented and may not be a good idea anyway. It seems we disagree on some things. A failing function should not corrupt the state. We also dont do that in other cases like SPS/PPS. This is also unexpected, so it should be documented. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country fall into chaos, be surprised about raise of fundamantalists. Drop more bombs, kill more people, be surprised about them taking revenge and drop even more bombs and strip your own citizens of their rights and freedoms. to be continued --pIgUhm2PSpi2KHBa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZpr/+AAKCRBhHseHBAsP qwdQAJ4kYugtK8fqVQ3B3Bp9ZNnXbXpG+ACfTyG4zG4mD9+VLmjt66WX/xHcZU0= =ZnwE -----END PGP SIGNATURE----- --pIgUhm2PSpi2KHBa-- --===============0466206605382400620== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0466206605382400620==--