From: Andrew Sayers <ffmpeg-devel@pileofstuff.org> To: ffmpeg-devel@ffmpeg.org Cc: Andrew Sayers <ffmpeg-devel@pileofstuff.org> Subject: [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size Date: Fri, 19 Jul 2024 14:54:09 +0100 Message-ID: <20240719135409.2921601-1-ffmpeg-devel@pileofstuff.org> (raw) In-Reply-To: <b9f755a5-be70-42ca-a4ce-34d35f8db788@gmail.com> These are accessed as AV_OPT_TYPE_IMAGE_SIZE AVOptions, so must be implemented as (signed) int's --- doc/APIchanges | 6 ++++++ libavfilter/version_major.h | 1 + libavfilter/vf_tile.c | 4 ++++ libavfilter/vf_untile.c | 4 ++++ 4 files changed, 15 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 5751216b24..e839d1b674 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,12 @@ The last version increases of all libraries were on 2024-03-07 API changes, most recent first: +2024-07-19 - xxxxxxxxxx - lavfi 10 - vf_tile.c + Convert TileContext::w and TileContext::h from unsigned to int + +2024-07-19 - xxxxxxxxxx - lavfi 10 - vf_untile.c + Convert UntileContext::w and UntileContext::h from unsigned to int + 2024-07-xx - xxxxxxxxxx - lavf 61 - avformat.h Deprecate avformat_transfer_internal_stream_timing_info() and av_stream_get_codec_timebase() without replacement. diff --git a/libavfilter/version_major.h b/libavfilter/version_major.h index c5e660eeda..a8dc790c0a 100644 --- a/libavfilter/version_major.h +++ b/libavfilter/version_major.h @@ -36,5 +36,6 @@ */ #define FF_API_LINK_PUBLIC (LIBAVFILTER_VERSION_MAJOR < 11) +#define FF_API_TILE_SIZE_TYPE (LIBAVFILTER_VERSION_MAJOR < 11) #endif /* AVFILTER_VERSION_MAJOR_H */ diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c index b45e739bb6..0076657c92 100644 --- a/libavfilter/vf_tile.c +++ b/libavfilter/vf_tile.c @@ -34,7 +34,11 @@ typedef struct TileContext { const AVClass *class; +#if FF_API_TILE_SIZE_TYPE unsigned w, h; +#else + int w, h; +#endif unsigned margin; unsigned padding; unsigned overlap; diff --git a/libavfilter/vf_untile.c b/libavfilter/vf_untile.c index f32f3e186b..5164e2efb0 100644 --- a/libavfilter/vf_untile.c +++ b/libavfilter/vf_untile.c @@ -28,7 +28,11 @@ typedef struct UntileContext { const AVClass *class; +#if FF_API_TILE_SIZE_TYPE unsigned w, h; +#else + int w, h; +#endif unsigned current; unsigned nb_frames; AVFrame *frame; -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-19 13:54 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-07-08 19:00 [FFmpeg-devel] [PATCH] Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned Andrew Sayers 2024-07-08 19:40 ` Marcus B Spencer 2024-07-08 19:59 ` [FFmpeg-devel] [PATCH v2] lavu/opt: " Andrew Sayers 2024-07-10 14:01 ` Paul B Mahol 2024-07-10 14:54 ` Andrew Sayers 2024-07-19 12:54 ` James Almer 2024-07-19 13:54 ` Andrew Sayers [this message] 2024-07-19 15:31 ` [FFmpeg-devel] [PATCH v2] avfilter: fix data type for {Tile, Untile}Context's image size Paul B Mahol 2024-07-19 15:45 ` Andrew Sayers 2024-07-23 14:42 ` [FFmpeg-devel] [PATCH v4] " Andrew Sayers 2024-07-23 15:17 ` [FFmpeg-devel] [PATCH v2] " James Almer 2024-07-23 16:17 ` Paul B Mahol 2024-07-23 16:24 ` Paul B Mahol 2024-07-23 16:36 ` James Almer 2024-07-23 20:00 ` Ronald S. Bultje 2024-07-23 22:10 ` Michael Niedermayer 2024-07-24 4:32 ` Michael Niedermayer 2024-07-24 4:49 ` Marvin Scholz (ePirat) 2024-07-24 13:08 ` Michael Niedermayer 2024-07-24 19:33 ` Rémi Denis-Courmont 2024-07-25 7:54 ` Ronald S. Bultje 2024-07-25 10:12 ` Rémi Denis-Courmont 2024-07-19 8:34 ` [FFmpeg-devel] [PATCH v2] lavu/opt: Mention that AV_OPT_TYPE_IMAGE_SIZE can be unsigned Andrew Sayers 2024-07-19 12:42 ` Paul B Mahol
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240719135409.2921601-1-ffmpeg-devel@pileofstuff.org \ --to=ffmpeg-devel@pileofstuff.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git