From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CFEE4BF82 for ; Thu, 18 Jul 2024 17:03:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D10768D97D; Thu, 18 Jul 2024 20:03:48 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BA4868D8F8 for ; Thu, 18 Jul 2024 20:03:41 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 916EEE0005 for ; Thu, 18 Jul 2024 17:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721322220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rcID8PWFFO6opi1e4mpmObH5+5fY3Jibz+6p/xQhqdE=; b=OnvR9GUAuzPU7AtOt9dcvj3NRTdfIKysgswVVAmLKG2JcZ+0Ot4ZSA2/xiqfz+1H7BlmHy rvrE5+szM0NCEdPjVuZEVGgs1S0kjZns10xlOSaK3Ux/+O41RiGOza0FRu3Yifd6DHBqy3 Irj95C7adDY1IbfHTThR7Q75l7LKXYkyJqfZu4R/kvn1fUyCVHi/tUH7jOzedKmc0UIhV8 22MLSatmpHg930Vv+tMh6b1trFjPPpHW3d1kHxXAfwGVE3cxanJERzGNZ/0uguJZHdpfyD TyMs+CGKMOZ3XOcRhkQpSf7AxlWSRcp1JssO+uooE2PZpfj+z0/5narPXgkZwg== Date: Thu, 18 Jul 2024 19:03:39 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240718170339.GD4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-13-anton@khirnov.net> <20240717223238.GW4991@pb2> <172129080994.21847.15080640617406361149@lain.khirnov.net> <20240718143151.GB4991@pb2> <172131565287.21847.1792634968888081802@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <172131565287.21847.1792634968888081802@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 13/39] lavc/ffv1: drop redundant PlaneContext.quant_table X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2767153290461330326==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2767153290461330326== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uJIW2pRtnvuncvpR" Content-Disposition: inline --uJIW2pRtnvuncvpR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 18, 2024 at 05:14:12PM +0200, Anton Khirnov wrote: [...] > diff --git a/libavcodec/ffv1dec_template.c b/libavcodec/ffv1dec_template.c > index 97a28b085a..d68bbda5be 100644 > --- a/libavcodec/ffv1dec_template.c > +++ b/libavcodec/ffv1dec_template.c > @@ -30,6 +30,7 @@ RENAME(decode_line)(FFV1Context *f, > { > PlaneContext *const p =3D &s->plane[plane_index]; > RangeCoder *const c =3D &s->c; > + const int16_t (*quant_table)[256] =3D f->quant_tables[p->quant_table= _index]; > int x; > int run_count =3D 0; > int run_mode =3D 0; > @@ -59,7 +60,7 @@ RENAME(decode_line)(FFV1Context *f, > return AVERROR_INVALIDDATA; > } >=20 > - context =3D RENAME(get_context)(f->quant_tables[p->quant_table_i= ndex], > + context =3D RENAME(get_context)(quant_table, > sample[1] + x, sample[0] + x, samp= le[1] + x); > if (context < 0) { > context =3D -context; that change is fine. the removial of the quant_table copy should be benchmarked thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --uJIW2pRtnvuncvpR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZplK4AAKCRBhHseHBAsP q/E9AKCDTK2VHmFN14FoZYg9mdSGluznYwCeIpJZIc2/JYtJLVK0CzrBc3kAzrE= =EtoX -----END PGP SIGNATURE----- --uJIW2pRtnvuncvpR-- --===============2767153290461330326== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2767153290461330326==--