From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B5D9E4BEC4 for ; Thu, 18 Jul 2024 10:48:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BAD4C68DA15; Thu, 18 Jul 2024 13:48:26 +0300 (EEST) Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63AD368D5B7 for ; Thu, 18 Jul 2024 13:48:20 +0300 (EEST) Received: from 0.b.4.b.7.4.0.8.c.4.a.5.d.8.b.2.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:2b8d:5a4c:8047:b4b0] helo=andrews-2024-laptop.lan) by painless-a.thn.aa.net.uk with esmtp (Exim 4.96) (envelope-from ) id 1sUOgN-000Wr5-2o for ffmpeg-devel@ffmpeg.org; Thu, 18 Jul 2024 11:48:19 +0100 From: Andrew Sayers To: ffmpeg-devel@ffmpeg.org Date: Thu, 18 Jul 2024 11:46:46 +0100 Message-ID: <20240718104757.2809396-1-ffmpeg-devel@pileofstuff.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/3] Protect against undocumented error codes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: I hadn't noticed av_fourcc2str() before - so long as it's patched to handle "!", it would be a clear improvement over the earlier patches. The example in the "!" patch is "BUG!", which is handled in error.c, but shows that "!" is considered a valid FourCC character. I think I understand the fate argument now, but this is my first fate patch - please review it as such! I still don't see the problem with asking for a bug report. If this patch is unacceptable, could you give an example of a code where we would reject a request to add an error string? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".