Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andrew Sayers <ffmpeg-devel@pileofstuff.org>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v3 0/3] Protect against undocumented error codes
Date: Thu, 18 Jul 2024 11:46:46 +0100
Message-ID: <20240718104757.2809396-1-ffmpeg-devel@pileofstuff.org> (raw)
In-Reply-To: <e16a94ab-5f61-0d89-3e57-968aa7455f82@passwd.hu>

I hadn't noticed av_fourcc2str() before - so long as it's patched to handle "!",
it would be a clear improvement over the earlier patches.

The example in the "!" patch is "BUG!", which is handled in error.c, but shows
that "!" is considered a valid FourCC character.

I think I understand the fate argument now, but this is my first fate patch -
please review it as such!

I still don't see the problem with asking for a bug report.  If this patch is
unacceptable, could you give an example of a code where we would reject a
request to add an error string?

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-07-18 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 15:13 [FFmpeg-devel] [PATCH] avutil/error: Provide better feedback about unknown " Andrew Sayers
2024-07-15 15:45 ` Marton Balint
2024-07-15 16:13   ` Andrew Sayers
2024-07-15 23:01     ` Marton Balint
2024-07-16 11:13       ` [FFmpeg-devel] [RFC PATCH v2 0/1] " Andrew Sayers
2024-07-16 11:13         ` [FFmpeg-devel] [RFC PATCH v2] " Andrew Sayers
2024-07-17 21:06           ` Michael Niedermayer
2024-07-18  9:26         ` [FFmpeg-devel] [RFC PATCH v2 0/1] " Marton Balint
2024-07-18 10:46           ` Andrew Sayers [this message]
2024-07-18 10:46             ` [FFmpeg-devel] [PATCH v3 1/3] avutil/utils: Allow "!" in FourCCs Andrew Sayers
2024-07-18 15:42               ` Paul B Mahol
2024-07-18 10:46             ` [FFmpeg-devel] [PATCH v3 2/3] avutil/error: Provide better feedback about unknown error codes Andrew Sayers
2024-07-18 10:46             ` [FFmpeg-devel] [PATCH v3 3/3] tests/fate/source-check: Check for AVERROR codes without error strings Andrew Sayers
2024-07-18 11:16           ` [FFmpeg-devel] [RFC PATCH v2 0/1] avutil/error: Provide better feedback about unknown error codes Zhao Zhili
2024-07-17  6:25       ` [FFmpeg-devel] [PATCH] " Anton Khirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718104757.2809396-1-ffmpeg-devel@pileofstuff.org \
    --to=ffmpeg-devel@pileofstuff.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git