From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 43CBB4BEA5 for ; Wed, 17 Jul 2024 22:49:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A973B68DAF8; Thu, 18 Jul 2024 01:49:49 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8525268DAE2 for ; Thu, 18 Jul 2024 01:49:43 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B54801C0002 for ; Wed, 17 Jul 2024 22:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721256582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1/6Vmue6KdMya5NJF3fxc+fmS3GgYBSf+sOimfmyBkc=; b=cHcHD2HQXreMCcQTmnZOx8KGFvjVJBviRLDziefd2nhuWVoyfeGT1gxf1Z5ODC2i222zXy XxOZ938npNWRHL94Wcbo3qFi1uDa54kdGR7JiYCo1KhRa9z4H5+Y/Kjndd91u1cKlVj7bv yKRNCL+OY5kDSkyR1Tu4F5atbMb2bgoVfprZnrenansAuW/jHcB+ptNmrlDTysWcdQvgx2 f7AsMrUCDxQJcPvre6snLeWdrMv19o2uiBr8O1MuFJLIyDmnXqhb532gjjhG7YruNzVgji 06TXAcmAkZNTYIdpZzgkNtyWTyLbki5oskrQ0R5PEYIZJtMidm4BctKKD8TGGQ== Date: Thu, 18 Jul 2024 00:49:41 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240717224941.GZ4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-9-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240716171155.31838-9-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 09/39] lavc/ffv1: move run_index to the per-slice context X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0335658929326630487==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0335658929326630487== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nOkP3B9e3ta8qQbV" Content-Disposition: inline --nOkP3B9e3ta8qQbV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2024 at 07:11:24PM +0200, Anton Khirnov wrote: > --- > libavcodec/ffv1.h | 3 ++- > libavcodec/ffv1dec.c | 6 +++--- > libavcodec/ffv1dec_template.c | 16 ++++++++-------- > libavcodec/ffv1enc.c | 6 +++--- > libavcodec/ffv1enc_template.c | 16 ++++++++-------- > 5 files changed, 24 insertions(+), 23 deletions(-) more complex code > @@ -140,13 +140,13 @@ static int decode_plane(FFV1Context *s, FFV1SliceCo= ntext *sc, > sample[0][w] =3D sample[0][w - 1]; > =20 > if (s->avctx->bits_per_raw_sample <=3D 8) { > - int ret =3D decode_line(s, w, sample, plane_index, 8); > + int ret =3D decode_line(s, sc, w, sample, plane_index, 8); > if (ret < 0) > return ret; > for (x =3D 0; x < w; x++) > src[x*pixel_stride + stride * y] =3D sample[1][x]; > } else { > - int ret =3D decode_line(s, w, sample, plane_index, s->avctx-= >bits_per_raw_sample); > + int ret =3D decode_line(s, sc, w, sample, plane_index, s->av= ctx->bits_per_raw_sample); > if (ret < 0) > return ret; > if (s->packed_at_lsb) { The need for passing an additional pointer around seems to me a net negative thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --nOkP3B9e3ta8qQbV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZphKhQAKCRBhHseHBAsP q5wvAJ0QMtJqJjgZDvnIROuNITKlg9xXZwCeNQM0iidXWnTjKlxfL0nAInS1f+8= =1JMq -----END PGP SIGNATURE----- --nOkP3B9e3ta8qQbV-- --===============0335658929326630487== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0335658929326630487==--