From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C9BC74BE8E for ; Wed, 17 Jul 2024 22:37:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 075FC68DADC; Thu, 18 Jul 2024 01:37:34 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DFD1468DA09 for ; Thu, 18 Jul 2024 01:37:26 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3FA2820002 for ; Wed, 17 Jul 2024 22:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721255846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bU83CD86ZAkyuuae2/tipozgc6WbjYI8CmCcLtqV4Tw=; b=aNuzE1OAC3AxHJNNUbyAeK1wE/ZYnoNvjHC0MBCfHqtX773o2RtIMkXs+G1uQ0GsArdEfe k4MsUxl+PftW5R8j02stnfdn+oBL6Wfz4OULBzamsSJV4qQpL8h0J+OG1kIzSRaKcgDb8+ EI9vrpDXnHlKZcQBu5lS23TUzpO5G/Xko5suE0Ufc8ggs+nqMlX0oyhzJqdJ00BGWLRno5 /tEFlwPLF2qkk3YyglcN+7CejtHddKuf/pwBBvmZt9S5dCtzd8pzInN1SZ4JRB6kQ92iux Zr8dsewnE5+HhuPNkn/Bs8W72Ix5lM6ldVhiOyPsGH1rJxebucV5O2hcn+jJdw== Date: Thu, 18 Jul 2024 00:37:25 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240717223725.GX4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-12-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240716171155.31838-12-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2270280066069378569==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2270280066069378569== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EcvL2e2K6sUZje1U" Content-Disposition: inline --EcvL2e2K6sUZje1U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote: > In all cases except decoding version 1 it's either not used, or contains > a copy of a table from quant_tables, which we can just as well use > directly. >=20 > When decoding version 1, we can just as well decode into > quant_tables[0], which would otherwise be unused. > --- > libavcodec/ffv1.h | 1 - > libavcodec/ffv1dec.c | 10 +++++++--- > libavcodec/ffv1enc.c | 6 ++---- > 3 files changed, 9 insertions(+), 8 deletions(-) the code is 1 line longer and using the first entry as a special case doesnt seem simpler thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. --EcvL2e2K6sUZje1U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZphHpQAKCRBhHseHBAsP q351AJ4ury2h7QUqzcefvVICgpLOGrN7xwCfSWKtGfTx0U9KGwbNRijnI65bhfA= =ewg2 -----END PGP SIGNATURE----- --EcvL2e2K6sUZje1U-- --===============2270280066069378569== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2270280066069378569==--