Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Stephen Hutchinson <qyot27@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Stephen Hutchinson <qyot27@gmail.com>
Subject: [FFmpeg-devel] [PATCH 2/2] avformat/avisynth: remove mutex lock from read_close
Date: Wed, 17 Jul 2024 18:05:24 -0400
Message-ID: <20240717220524.8240-1-qyot27@gmail.com> (raw)
In-Reply-To: <AS8P250MB0744D0153076A88334F5C6E08FD92@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Signed-off-by: Stephen Hutchinson <qyot27@gmail.com>
---
After asking about this and testing with AviSynth+ 3.7.3 and
AviSynth 2.6, it would appear that this isn't necessary.
If it was to handle an edge case and said case reappears,
it can be re-evaluated then.

 libavformat/avisynth.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c
index 5d1ecc0bf6..e586fd8ce3 100644
--- a/libavformat/avisynth.c
+++ b/libavformat/avisynth.c
@@ -1085,11 +1085,7 @@ static int avisynth_read_packet(AVFormatContext *s, AVPacket *pkt)
 
 static av_cold int avisynth_read_close(AVFormatContext *s)
 {
-    if (ff_mutex_lock(&avisynth_mutex))
-        return AVERROR_UNKNOWN;
-
     avisynth_context_destroy(s->priv_data);
-    ff_mutex_unlock(&avisynth_mutex);
     return 0;
 }
 
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2024-07-17 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-07  3:25 [FFmpeg-devel] [PATCH] avformat/avisynth: remove atexit() handler Stephen Hutchinson
2024-07-07 13:50 ` Andreas Rheinhardt
2024-07-07 17:46   ` Stephen Hutchinson
2024-07-17 22:10     ` Stephen Hutchinson
2024-07-17 22:05   ` Stephen Hutchinson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717220524.8240-1-qyot27@gmail.com \
    --to=qyot27@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git