From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 880E5465C2 for ; Wed, 17 Jul 2024 20:52:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9996C68D957; Wed, 17 Jul 2024 23:52:05 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D325E68D854 for ; Wed, 17 Jul 2024 23:51:58 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CE21940003 for ; Wed, 17 Jul 2024 20:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721249518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwb+5/6Q42VUBUb/06hFC4DGTRo/LDBNeEGMtxFn8yA=; b=U2L6zyfxrHkXwQ9UiRCg1OwtQLy9jIqxwJ+XC/TL+AsWgVcz7dZagtp7uXF4mQGJ2ucljY UTQEyulHMixg6BBJGmSpxwzC9ljZV1Sm1Iwc6iNxvf/KDtSS1hnjWkDX5jzavaIh3bPYk5 bTE1fv5pQqvB8TIsjdqlzwu3Wgwxt85yto9e8gRnMK4nL1h9KNk8mDVs0fnwdS3e08xNYz qYpsdseTbn4qIPu7ML2ODkozRCcXyOZ+8+fgc6ckQ0xDvYSyn/9Xf33L52E8Bp+WFfH3wY Gw0nVmek4v7IPMSUY1Cn2QfJdtlGIRT4fJ3Xkj3dbY6eSD9hwCxmFrnaiGwGsg== Date: Wed, 17 Jul 2024 22:51:56 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240717205156.GT4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-28-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20240716171155.31838-28-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 28/39] lavc/ffv1dec: fix races in accessing FFV1SliceContext.slice_damaged X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7014636787873849739==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7014636787873849739== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4ZYwxBGyy4rg4AI1" Content-Disposition: inline --4ZYwxBGyy4rg4AI1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2024 at 07:11:43PM +0200, Anton Khirnov wrote: > That variable is shared between frame threads in the same defective way > described in the previous commit. Fix it by adding a RefStruct-managed > arrays of flags that is propagated across frame threads in the standard > manner. >=20 > Remove now-unused FFV1Context.fsrc > --- > libavcodec/ffv1.c | 2 ++ > libavcodec/ffv1.h | 3 ++- > libavcodec/ffv1dec.c | 24 ++++++++++-------------- > 3 files changed, 14 insertions(+), 15 deletions(-) breaks error handling and introduces a race try any of the files from: https://samples.ffmpeg.org/avi/ffv1/ =2E/ffmpeg -i ffv1.3-01ec.avi -f crc - the results are vissually worse, and differ from run to run also =2E/ffmpeg -thread_type slice -i ffv1.3-01ec.avi -f crc - has issues, its not just the default thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --4ZYwxBGyy4rg4AI1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZpgu6QAKCRBhHseHBAsP q5SOAJ4+SGD/4cSw9c0U44CI9GBKG0EulACeLB8rQyOytLSLKpSU4VscuD9vHkE= =X08c -----END PGP SIGNATURE----- --4ZYwxBGyy4rg4AI1-- --===============7014636787873849739== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7014636787873849739==--