From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C79734BC96 for ; Tue, 16 Jul 2024 12:25:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB5E368DA16; Tue, 16 Jul 2024 15:25:12 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED05F68D93E for ; Tue, 16 Jul 2024 15:25:05 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 611B26000B for ; Tue, 16 Jul 2024 12:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721132705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zHPnqs4BiNF1nWffBIm82EHhD+SJBxvB2xSbtWwr8YI=; b=h6D7Un/va+hcO3N4I7Ik/NmqCqUQsqbYRusCH7FGvSZ4DSp5pRg8Jz4AQPSWWnQkjdzxxn f8e8Dy2vwAq+S+EHf4547yFN2/QH1R42PMbu8xM0xp4A6z1hPTmJhTvRUPGYUbbQYQBzKB 8vzP+tM/CJgmC/5do5vt/wGaELaTNPF/W46R54rZbvSE1NJrtOpXEja2HmSzrFEn5z4OeN NwKBnnMMQlkhnmhYoNaoeBJ7YDpkLc/RDcfNfqy85R66+KHQPgxoenN24H3m7EXWMktJqB NZeEctA/TxxhhzXaj1V4Dk/sVYGp6kEDYul/mrNvTZAMtUJ99gUmGbn3gBqe3Q== Date: Tue, 16 Jul 2024 14:25:04 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240716122504.GL4991@pb2> References: <20240626224510.GS4991@pb2> <20240714195541.GE4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer? X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1113745317596742371==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1113745317596742371== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="frK4hI1X9U277v5Y" Content-Disposition: inline --frK4hI1X9U277v5Y Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 15, 2024 at 02:36:15PM +0200, Vittorio Giovara wrote: > On Sun, Jul 14, 2024 at 9:55=E2=80=AFPM Michael Niedermayer > wrote: >=20 > > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Michajlow wrote: > > > On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow > > wrote: > > > > > > > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > > > > wrote: > > > > > > > > > > On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > > > > > > Hi, > > > > > > > > > > > > Like in the topic. I think it would be useful to enable MSAN on > > > > > > OSS-Fuzz. We get some tiny issues and it would be probably good= to > > > > > > have them tracked upstream. All infra is here, so enabling it i= s as > > > > > > simple as adding it to the project.yaml. Except libbz2.so and > > libz.so > > > > > > would have to be built inline instead, looking at the build.sh, > > they > > > > > > are prebuilt. The rest should just work (TM), but needs to be > > tested. > > > > > > You can set an "experimental' flag to have it not create issues= on > > > > > > monorail, initially. > > > > > > > > > > I assumed ossfuzz would enable all sanitizers by default > > > > > > > > They do not do that by default, because MSAN requires all dependenc= ies > > > > to be instrumented too. See > > > > > > https://google.github.io/oss-fuzz/getting-started/new-project-guide/#sa= nitizers > > > > > > > > Looking at build.sh for ffmpeg, it should be fine to enable it. > > > > Obviously I have not tested everything, but I was running some tests > > > > locally with MSAN and also tested it with mpv oss-fuzz builds where= we > > > > build ffmpeg too with MSAN. > > > > > > > > - Kacper > > > > > > I've sent a PR to enable MSAN and a few other build improvements. > > > Please take a look https://github.com/google/oss-fuzz/pull/12211 > > > > > > > > Also, would it be ok to add myself to auto_ccs for ffmpeg? Mostly to > > > monitor what issues are reported upstream, as we get some reports in > > > mpv fuzzing and I never know if I should report it upstream (ffmpeg) > > > or it is already found by first-party fuzzing and I shouldn't make > > > more noise. > > > > you are welcome to submit bug reports, you are welcome to submit bug fi= xes > > if you find issues in FFmpeg. > > > > If someones work in FFmpeg or rather FFmpeg benefits from someone having > > access to the reports, then (s)he should receive access. This seems not > > to apply here > > >=20 > Disagree - this is not the right way to attract new contributors. no ? did you do a study ? try this: A. "please we need more maintainers" (we tried this i think) B. gently push someone away (now people are angry, they want their rights, their access, they want = to contribute ...) ;) >=20 > Also i expect the number of outstanding ossfuzz issues to decrease now > > after the bulk of coverity issues has been dealt with > > >=20 > The majority of coverity issues are false positives, I fail to see the > relationship here. I do both coverity and ossfuzz work, and while i have done significantly mo= re in the last months than i did last year, i still have falling a bit behind = with ossfuzz fixing. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact --frK4hI1X9U277v5Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZpZmmwAKCRBhHseHBAsP qy5bAJ9AiLxRmWQW+maih56KTi2QqsO0yACfWHB7/qxZRgSNt0Xd2Ak5o6hUO0g= =7/z1 -----END PGP SIGNATURE----- --frK4hI1X9U277v5Y-- --===============1113745317596742371== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1113745317596742371==--