[FFmpeg-devel] [PATCH 1/3] avformat/lmlm4: Move subtraction after check

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 1/3] avformat/lmlm4: Move subtraction after check
Date: Sat, 13 Jul 2024 17:51:03 +0200
Message-ID: <20240713155105.2161442-1-michael@niedermayer.cc> (raw)

This is not a bugfix in code but coverity only, it does look a little nicer though

Fixes: CID732224

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/lmlm4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/lmlm4.c b/libavformat/lmlm4.c
index 209b544ccd8..c8355e7a8d6 100644
--- a/libavformat/lmlm4.c
+++ b/libavformat/lmlm4.c
@@ -91,7 +91,6 @@ static int lmlm4_read_packet(AVFormatContext *s, AVPacket *pkt)
     frame_type  = avio_rb16(pb);
     packet_size = avio_rb32(pb);
     padding     = -packet_size & 511;
-    frame_size  = packet_size - 8;
 
     if (frame_type > LMLM4_MPEG1L2 || frame_type == LMLM4_INVALID) {
         av_log(s, AV_LOG_ERROR, "invalid or unsupported frame_type\n");
@@ -102,6 +101,7 @@ static int lmlm4_read_packet(AVFormatContext *s, AVPacket *pkt)
         return AVERROR(EIO);
     }
 
+    frame_size  = packet_size - 8;
     if ((ret = av_get_packet(pb, pkt, frame_size)) <= 0)
         return AVERROR(EIO);
 
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
