From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D5B04B6A2 for ; Fri, 12 Jul 2024 20:37:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2F9568DB24; Fri, 12 Jul 2024 23:37:15 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15C9668D97E for ; Fri, 12 Jul 2024 23:37:10 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 64804FF804 for ; Fri, 12 Jul 2024 20:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720816629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xSVLM0m4r2ws+kJODLGsJcnddWKi+0LyXTamZ0lAPsQ=; b=dxCBqvOfx/SQ+Bueb1I1a++vXt2bF/4HNMFyYOjF65bkBcoj0WO/pNlawmoy+pfH0+rs8v a6SPy+aORMpwWReVrnug0Aa22SbnCdJUciUCJ7khRoGg+8LeVA4TIoK9ErHLT4lkaO/L6u NmreIg5RQfPLv28wJRuxN0v9nmYDnNPgDIqqslEhGgS3I8YYRHWHJ2E0LXpdDbd0q2NK9V lOHlCyhTyTt5akGdDZgWXNrPNIxaG6+e8AUtlOVJKF5VMNV/7nAg/lYM0anoCGAP0xyq8m JbCg91QR1GroOt+G69APZLc//Kez935ekkfBPZ0yMCZwHuBJMvNJyEe9W9na+w== Date: Fri, 12 Jul 2024 22:37:08 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240712203708.GT4991@pb2> References: <20240707184729.3525852-1-michael@niedermayer.cc> <20240707184729.3525852-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vaapi_h264: Do not store our error code in VASliceParameterBufferH264 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7103943086172351504==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7103943086172351504== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZZTOI0WqqOZ0yWqI" Content-Disposition: inline --ZZTOI0WqqOZ0yWqI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2024 at 06:11:54AM +0000, Xiang, Haihao wrote: > On So, 2024-07-07 at 20:47 +0200, Michael Niedermayer wrote: > > I am not sure this is possible (thus this requires review) > >=20 > > Fixes: CID1604570 Overflowed constant > >=20 > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavcodec/vaapi_h264.c | 6 +++++- > > =A01 file changed, 5 insertions(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/vaapi_h264.c b/libavcodec/vaapi_h264.c > > index 398e92568c2..77819a64a4e 100644 > > --- a/libavcodec/vaapi_h264.c > > +++ b/libavcodec/vaapi_h264.c > > @@ -342,6 +342,10 @@ static int vaapi_h264_decode_slice(AVCodecContext = *avctx, > > =A0=A0=A0=A0 const H264SliceContext *sl=A0 =3D &h->slice_ctx[0]; > > =A0=A0=A0=A0 VASliceParameterBufferH264 slice_param; > > =A0=A0=A0=A0 int err; > > +=A0=A0=A0 int slice_type =3D ff_h264_get_slice_type(sl); > > + > > +=A0=A0=A0 if (slice_type < 0) > > +=A0=A0=A0=A0=A0=A0=A0 return slice_type; >=20 > sl->slice_type should be one of AV_PICTURE_TYPE_P, AV_PICTURE_TYPE_B, > AV_PICTURE_TYPE_I, AV_PICTURE_TYPE_SP and AV_PICTURE_TYPE_SI when this ca= llback > function is called, I don't think the if statement is required.=20 patch dropped, i will mark this as false positive thanks [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange --ZZTOI0WqqOZ0yWqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZpGT8QAKCRBhHseHBAsP q0CuAKCTusVGthVGV2D+08Xlvr026m1mxQCfag74qo8Sr7YRBWWFvan3whJvEVU= =nPoO -----END PGP SIGNATURE----- --ZZTOI0WqqOZ0yWqI-- --===============7103943086172351504== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7103943086172351504==--