From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 505FC4AB49 for ; Fri, 12 Jul 2024 19:59:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A5B3468DBA0; Fri, 12 Jul 2024 22:59:40 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C813468DA0B for ; Fri, 12 Jul 2024 22:59:33 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 161C3FF803 for ; Fri, 12 Jul 2024 19:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720814373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EfXJ0ckGu69bFNHV0QG/QykR3Irr14EBKqahuV/9KvY=; b=ULuCNuc7ksZmNDGVMdFnshZRS1PljUXflfeObmZOjwnrhsieWpoJgkGIH0/PQy2/geE9Y7 dKsRgHm2Qmnx3c9ON5+iqg/ABTNCUowNeReCf3l1QnOBnvgQrAy37N6Hrq2zpVm3cukHAu Db14Bjg98GONI7x9S8alcokMUDsgshLWvrUZgY8EAblh5wVfZKVbc0rU+NNJXZ/kZz1tuF fj1kiFNMEoQh/N7yGFoU+n21SVELNlTjRQlWFfe6xozLt96Z69ccxA9vY03tEnS7ulP7M1 lgUzozZ8u3xYfLZgYyMOxM9sueuceXZH/IxuFnBsiPy4/HyVmOjSTUVqtcvO5A== Date: Fri, 12 Jul 2024 21:59:32 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240712195932.GR4991@pb2> References: <20240710225012.691594-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/6] avfilter/vf_tiltandshift: Free dst on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8458602306700657441==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8458602306700657441== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="onT/iYtSweZVW9zT" Content-Disposition: inline --onT/iYtSweZVW9zT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 12, 2024 at 12:19:29AM +0200, Vittorio Giovara wrote: > On Thu, Jul 11, 2024 at 12:50=E2=80=AFAM Michael Niedermayer > wrote: >=20 > > Fixes: CID1559901 Resource leak > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_tiltandshift.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshif= t.c > > index b49a713339d..08bcb062473 100644 > > --- a/libavfilter/vf_tiltandshift.c > > +++ b/libavfilter/vf_tiltandshift.c > > @@ -237,8 +237,10 @@ static int output_frame(AVFilterLink *outlink) > > > > // set correct timestamps and props as long as there is proper inp= ut > > ret =3D av_frame_copy_props(dst, s->input); > > - if (ret < 0) > > + if (ret < 0) { > > + av_frame_free(&dst); > > return ret; > > + } > > > > // discard frame at the top of the list since it has been fully > > processed > > list_remove_head(s); > > -- > > >=20 > lgtm will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --onT/iYtSweZVW9zT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZpGLJAAKCRBhHseHBAsP q0sCAJ99NyTY/0cPk/sQeHRK88z5gT4yLQCfRJ48ZmQGQ59NR2CVjUL+xQP0ibM= =bUVI -----END PGP SIGNATURE----- --onT/iYtSweZVW9zT-- --===============8458602306700657441== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8458602306700657441==--