Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 3162 bytes --]

On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote:
> ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Mon Jul  8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer
> 
> avformat/mov: export cropping values from clap boxes
> 
> Addresses part of ticket #7437.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c
> ---
> 
>  libavformat/mov.c                       | 74 +++++++++++++++++++++++++++++++++
>  tests/ref/fate/aic                      | 32 +++++++-------
>  tests/ref/fate/prores-transparency      |  4 +-
>  tests/ref/fate/prores-transparency_skip |  4 +-
>  4 files changed, 94 insertions(+), 20 deletions(-)

breaks:

./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov

[dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are:
[dvvideo @ 0x7fd2d8011980] Frame size: 720x480; pixel format: yuv411p, framerate: 30000/1001
[dvvideo @ 0x7fd2d8011980] Frame size: 720x576; pixel format: yuv420p, framerate: 25/1
[dvvideo @ 0x7fd2d8011980] Frame size: 720x576; pixel format: yuv411p, framerate: 25/1
[dvvideo @ 0x7fd2d8011980] Frame size: 720x480; pixel format: yuv422p, framerate: 30000/1001
[dvvideo @ 0x7fd2d8011980] Frame size: 720x576; pixel format: yuv422p, framerate: 25/1
[dvvideo @ 0x7fd2d8011980] Frame size: 1280x1080; pixel format: yuv422p, framerate: 30000/1001
[dvvideo @ 0x7fd2d8011980] Frame size: 1440x1080; pixel format: yuv422p, framerate: 25/1
[dvvideo @ 0x7fd2d8011980] Frame size: 960x720; pixel format: yuv422p, framerate: 60000/1001
[dvvideo @ 0x7fd2d8011980] Frame size: 960x720; pixel format: yuv422p, framerate: 50/1
[dvvideo @ 0x7fd2d8011980] Frame size: 720x576; pixel format: yuv420p, framerate: 25/1
[dvvideo @ 0x5592d5bb9040] ff_frame_thread_encoder_init failed
[vost#0:0/dvvideo @ 0x5592d5bb8b80] Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height.
[vf#0:0 @ 0x5592d5ba6e00] Error sending frames to consumers: Invalid argument
[vf#0:0 @ 0x5592d5ba6e00] Task finished with error code: -22 (Invalid argument)
[vf#0:0 @ 0x5592d5ba6e00] Terminating thread with return code -22 (Invalid argument)
[vost#0:0/dvvideo @ 0x5592d5bb8b80] Could not open encoder before EOF
[vost#0:0/dvvideo @ 0x5592d5bb8b80] Task finished with error code: -22 (Invalid argument)
[vost#0:0/dvvideo @ 0x5592d5bb8b80] Terminating thread with return code -22 (Invalid argument)
[out#0/mov @ 0x5592d5bb79c0] Nothing was written into output file, because at least one of its streams received no packets.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

[James Almer]

On 7/12/2024 1:53 PM, Michael Niedermayer wrote:
> On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote:
>> ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Mon Jul  8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer
>>
>> avformat/mov: export cropping values from clap boxes
>>
>> Addresses part of ticket #7437.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c
>> ---
>>
>>   libavformat/mov.c                       | 74 +++++++++++++++++++++++++++++++++
>>   tests/ref/fate/aic                      | 32 +++++++-------
>>   tests/ref/fate/prores-transparency      |  4 +-
>>   tests/ref/fate/prores-transparency_skip |  4 +-
>>   4 files changed, 94 insertions(+), 20 deletions(-)
> 
> breaks:
> 
> ./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov
> 
> [dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are:

The input file has a clap box that defines cropping, which began being 
applied by default after the aforementioned commit. You should add 
"-apply_cropping 0" to disable all cropping or "-apply_cropping 2" to 
only apply codec level cropping.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1849 bytes --]

On Fri, Jul 12, 2024 at 01:57:43PM -0300, James Almer wrote:
> On 7/12/2024 1:53 PM, Michael Niedermayer wrote:
> > On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote:
> > > ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Mon Jul  8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer
> > > 
> > > avformat/mov: export cropping values from clap boxes
> > > 
> > > Addresses part of ticket #7437.
> > > 
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > 
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c
> > > ---
> > > 
> > >   libavformat/mov.c                       | 74 +++++++++++++++++++++++++++++++++
> > >   tests/ref/fate/aic                      | 32 +++++++-------
> > >   tests/ref/fate/prores-transparency      |  4 +-
> > >   tests/ref/fate/prores-transparency_skip |  4 +-
> > >   4 files changed, 94 insertions(+), 20 deletions(-)
> > 
> > breaks:
> > 
> > ./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov
> > 
> > [dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are:
> 
> The input file has a clap box that defines cropping, which began being
> applied by default after the aforementioned commit.

I did realize that, i reported that anyway as it was a interresting failure


> You should add
> "-apply_cropping 0" to disable all cropping or "-apply_cropping 2" to only
> apply codec level cropping.

thx ill use that

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes

[James Almer]

On 7/12/2024 4:34 PM, Michael Niedermayer wrote:
> On Fri, Jul 12, 2024 at 01:57:43PM -0300, James Almer wrote:
>> On 7/12/2024 1:53 PM, Michael Niedermayer wrote:
>>> On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote:
>>>> ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Mon Jul  8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer
>>>>
>>>> avformat/mov: export cropping values from clap boxes
>>>>
>>>> Addresses part of ticket #7437.
>>>>
>>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>>>
>>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c
>>>> ---
>>>>
>>>>    libavformat/mov.c                       | 74 +++++++++++++++++++++++++++++++++
>>>>    tests/ref/fate/aic                      | 32 +++++++-------
>>>>    tests/ref/fate/prores-transparency      |  4 +-
>>>>    tests/ref/fate/prores-transparency_skip |  4 +-
>>>>    4 files changed, 94 insertions(+), 20 deletions(-)
>>>
>>> breaks:
>>>
>>> ./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov
>>>
>>> [dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are:
>>
>> The input file has a clap box that defines cropping, which began being
>> applied by default after the aforementioned commit.
> 
> I did realize that, i reported that anyway as it was a interresting failure
> 
> 
>> You should add
>> "-apply_cropping 0" to disable all cropping or "-apply_cropping 2" to only
>> apply codec level cropping.
> 
> thx ill use that

All values for apply_cropping are documented in ffmpeg.texi. It used to 
be a bool but now it also accepts 2 and 3 (And const aliases for all 
four values).

I wouldn't use 0 in general, before or after the above commit, as codec 
level cropping is almost always desirable (1080p h264 samples would 
decode as 1088 lines otherwise, for example), so IMO use 2/codec to 
disable container cropping and only leave codec cropping on for this 
kind of scenario.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".