[FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

[James Almer]

Same as the framecrc muxer. This will allow callers to analize changes in these
values between filters within a list.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/bsf/showinfo.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c
index 4e31e0b5cb..0899263545 100644
--- a/libavcodec/bsf/showinfo.c
+++ b/libavcodec/bsf/showinfo.c
@@ -23,6 +23,7 @@
 #include "bsf.h"
 #include "bsf_internal.h"
 
+#include "libavutil/internal.h"
 #include "libavutil/log.h"
 #include "libavutil/timestamp.h"
 
@@ -45,11 +46,18 @@ static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
            "pts:%s pt:%s "
            "dts:%s dt:%s "
            "ds:%"PRId64" d:%s "
-           "\n",
            priv->nb_packets, pkt->size,
            av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in),
            av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in),
            pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in));
+    if (pkt->flags != AV_PKT_FLAG_KEY)
+        av_log(ctx, AV_LOG_INFO, ", F=0x%0X", pkt->flags);
+    if (pkt->side_data_elems) {
+        av_log(ctx, AV_LOG_INFO, ", S=%d", pkt->side_data_elems);
+        for (int i = 0; i < pkt->side_data_elems; i++)
+            av_log(ctx, AV_LOG_INFO, ", %8"SIZE_SPECIFIER, pkt->side_data[i].size);
+    }
+    av_log(ctx, AV_LOG_INFO, "\n");
 
     priv->nb_packets++;
 
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/bsf/showinfo.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c
index 0899263545..57da3fc73c 100644
--- a/libavcodec/bsf/showinfo.c
+++ b/libavcodec/bsf/showinfo.c
@@ -23,6 +23,7 @@
 #include "bsf.h"
 #include "bsf_internal.h"
 
+#include "libavutil/adler32.h"
 #include "libavutil/internal.h"
 #include "libavutil/log.h"
 #include "libavutil/timestamp.h"
@@ -34,22 +35,25 @@ typedef struct ShowinfoContext {
 static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
 {
     ShowinfoContext *priv = ctx->priv_data;
+    uint32_t crc;
     int ret;
 
     ret = ff_bsf_get_packet_ref(ctx, pkt);
     if (ret < 0)
         return ret;
 
+    crc = av_adler32_update(0, pkt->data, pkt->size);
     av_log(ctx, AV_LOG_INFO,
            "n:%7"PRIu64" "
            "size:%7d "
            "pts:%s pt:%s "
            "dts:%s dt:%s "
            "ds:%"PRId64" d:%s "
+           "0x%08"PRIx32,
            priv->nb_packets, pkt->size,
            av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in),
            av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in),
-           pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in));
+           pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in), crc);
     if (pkt->flags != AV_PKT_FLAG_KEY)
         av_log(ctx, AV_LOG_INFO, ", F=0x%0X", pkt->flags);
     if (pkt->side_data_elems) {
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

[Anton Khirnov]

Quoting James Almer (2024-07-12 02:33:06)
> Same as the framecrc muxer.

IOW obfuscated and user-hostile.

Please don't.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum

[Anton Khirnov]

Quoting James Almer (2024-07-12 02:33:07)
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/bsf/showinfo.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c
> index 0899263545..57da3fc73c 100644
> --- a/libavcodec/bsf/showinfo.c
> +++ b/libavcodec/bsf/showinfo.c
> @@ -23,6 +23,7 @@
>  #include "bsf.h"
>  #include "bsf_internal.h"
>  
> +#include "libavutil/adler32.h"
>  #include "libavutil/internal.h"
>  #include "libavutil/log.h"
>  #include "libavutil/timestamp.h"
> @@ -34,22 +35,25 @@ typedef struct ShowinfoContext {
>  static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
>  {
>      ShowinfoContext *priv = ctx->priv_data;
> +    uint32_t crc;
>      int ret;
>  
>      ret = ff_bsf_get_packet_ref(ctx, pkt);
>      if (ret < 0)
>          return ret;
>  
> +    crc = av_adler32_update(0, pkt->data, pkt->size);
>      av_log(ctx, AV_LOG_INFO,
>             "n:%7"PRIu64" "
>             "size:%7d "
>             "pts:%s pt:%s "
>             "dts:%s dt:%s "
>             "ds:%"PRId64" d:%s "
> +           "0x%08"PRIx32,

could you prefix it with checksum: or something, so it's clear what it
means?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

[James Almer]

On 7/13/2024 10:46 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-07-12 02:33:06)
>> Same as the framecrc muxer.
> 
> IOW obfuscated and user-hostile.
> 
> Please don't.

You mean to not implement this in any form, or try to make it more user 
friendly? I could remove the flags (which is admittedly obfuscated), and 
only leave the crc which is useful to see in the middle of a bitstream 
filter list.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

[Anton Khirnov]

Quoting James Almer (2024-07-13 15:49:48)
> On 7/13/2024 10:46 AM, Anton Khirnov wrote:
> > Quoting James Almer (2024-07-12 02:33:06)
> >> Same as the framecrc muxer.
> > 
> > IOW obfuscated and user-hostile.
> > 
> > Please don't.
> 
> You mean to not implement this in any form, or try to make it more user 
> friendly?

The latter, if you want to spend effort on it. It is potentially useful
information, but in this form it's incomprehensible without reading the
code.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avcodec/bsf/showinfo: print packet data checksum

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/bsf/showinfo.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c
index 4e31e0b5cb..715b160b60 100644
--- a/libavcodec/bsf/showinfo.c
+++ b/libavcodec/bsf/showinfo.c
@@ -23,6 +23,7 @@
 #include "bsf.h"
 #include "bsf_internal.h"
 
+#include "libavutil/adler32.h"
 #include "libavutil/log.h"
 #include "libavutil/timestamp.h"
 
@@ -33,23 +34,26 @@ typedef struct ShowinfoContext {
 static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
 {
     ShowinfoContext *priv = ctx->priv_data;
+    uint32_t crc;
     int ret;
 
     ret = ff_bsf_get_packet_ref(ctx, pkt);
     if (ret < 0)
         return ret;
 
+    crc = av_adler32_update(0, pkt->data, pkt->size);
     av_log(ctx, AV_LOG_INFO,
            "n:%7"PRIu64" "
            "size:%7d "
            "pts:%s pt:%s "
            "dts:%s dt:%s "
            "ds:%"PRId64" d:%s "
+           "adler32:0x%08"PRIx32
            "\n",
            priv->nb_packets, pkt->size,
            av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in),
            av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in),
-           pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in));
+           pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in), crc);
 
     priv->nb_packets++;
 
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec/bsf/showinfo: print packet data checksum

[Anton Khirnov]

Quoting James Almer (2024-07-13 16:05:35)
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/bsf/showinfo.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

LGTM

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".