From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 196104B624 for ; Wed, 10 Jul 2024 17:55:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7064C68DB75; Wed, 10 Jul 2024 20:55:40 +0300 (EEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 180A668DB5C for ; Wed, 10 Jul 2024 20:55:34 +0300 (EEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-70b0d0fefe3so59083b3a.2 for ; Wed, 10 Jul 2024 10:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720634131; x=1721238931; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=P7Ilw09IVRSz1Fz3qOzRDVgQ2Hx4H1BKRRUe4HR4nCc=; b=e3Zg3chppkhkEa9QVJFCAnC0p7aGHNDNwjqUMDra4TpYVGIKYNUutoKxMaS7ExE1UF 49kGZkzu59hS4tBpRZApvbgDriBTrKI7yhosWxaZA7QOoqCgsdhgpPCWEutFFR7Nf30J yxDe5HvfU1JCevGvFaEWUFEixvK7riwI0mb0r8fFlkDSvCKvp1SOAM1AkE8e8fPmdlM4 W0cITVhhDNonm7IRtUzcWnmew7MQUi+sU1axxSlEUFWTQt9c3FeLzWLExrpcUQNtNbJG WV97Jw5h94x6TQJUzxqptYzHHbjqbkfntZmx/qywy/I+Z2TabwVltdyYo68ruiOTf8aY XfgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720634131; x=1721238931; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7Ilw09IVRSz1Fz3qOzRDVgQ2Hx4H1BKRRUe4HR4nCc=; b=STlvexvOTnpwv3vBReOD1gUbKf2Z833Iwhu4cqnVZw4im9pXO6jgyS0vRJQ2EJZ1aI rye2VKLjZ9MBM7Rh1jznkbhHCX0PrmcSLWPxe7xxr1DGvMPitdy85XLOCiwalGew2A4u TNvPGefgLJKoDh3nNws0h+OM1vEpmFRlG2qh8uypAIgtiJqOULb8RIZUV/3d5oWTn7zW hj3D3ko0b9pzVSOUa8qZJCmGkf8JJ1dwh5W9ds/85imJ9O/zA2Az49gh5Pv0I3m2UivE Xq/twF07z5zjNIjDlLo37g0WVp7L/Q9q9EJKgmhM5anzBM8IuEXIta9cO3QsYgdbeJBl tSIg== X-Gm-Message-State: AOJu0YygDy8HxjKcqInHPniKiiMdZA4SH1Hwt23viuqlAk+Qhh1t0COz jG6Hrne9eZ++Fl1VCEKtfE9zUkFYsZA3JgWfrTe/eiEQuaz5T54J87PU4w== X-Google-Smtp-Source: AGHT+IEGhkiFmjchrWzDSIUsBzJoBRsQqBk2uw0T/4iIpLaz1GUJugEokluilLFfeZ9GK42uP8fJfA== X-Received: by 2002:a05:6a20:cfa4:b0:1c3:b269:22f with SMTP id adf61e73a8af0-1c3b2690274mr273881637.12.1720634130762; Wed, 10 Jul 2024 10:55:30 -0700 (PDT) Received: from localhost.localdomain ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ac0c47sm36420875ad.192.2024.07.10.10.55.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:55:30 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Jul 2024 14:55:18 -0300 Message-ID: <20240710175518.15937-1-jamrial@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: use a bprint buffer for the crop filter arguments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Should ensure no truncation ocurrs. The input sample aspect ratio applies to the pre-cropping dimensions, so update it. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 097bd2ed48..bb88c6711a 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -1702,12 +1702,12 @@ static int configure_input_video_filter(FilterGraph *fg, AVFilterGraph *graph, av_assert0(desc); if ((ifp->opts.flags & IFILTER_FLAG_CROP)) { - char crop_buf[64]; - snprintf(crop_buf, sizeof(crop_buf), "w=iw-%d-%d:h=ih-%d-%d:x=%d:y=%d", + av_bprint_clear(&args); + av_bprintf(&args, "w=iw-%d-%d:h=ih-%d-%d:x=%d:y=%d", ifp->opts.crop_left, ifp->opts.crop_right, ifp->opts.crop_top, ifp->opts.crop_bottom, ifp->opts.crop_left, ifp->opts.crop_top); - ret = insert_filter(&last_filter, &pad_idx, "crop", crop_buf); + ret = insert_filter(&last_filter, &pad_idx, "crop", args.str); if (ret < 0) return ret; } -- 2.45.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".