From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7BEF84BA2D for ; Wed, 10 Jul 2024 12:29:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6DCE768DA30; Wed, 10 Jul 2024 15:29:54 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 814FB68DA00 for ; Wed, 10 Jul 2024 15:29:48 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4140F20007 for ; Wed, 10 Jul 2024 12:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720614587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hAHz3ePgnmFulJca4oJSIrTc8r/x05R0fnj3LhGTOwI=; b=gnc+vH1l09W6ah1zYBNDmvQLSrpkzeJpA4e7eLAER+ZbmNjTsmEsN9+iR5nqtY6Nf8fdCj klfk7FHet2oZsrfnrikDIzR9CZeYpENFHvMaVPVdWdY2SqiUsjViHmoEyfS/4hpFjMUCiq bakki4AmNyVX4SBG1d4ELBasAChltoGcZQLN4tMr8uyo0RgPoIf11GEkRtIKvJl+trX66V arRndz1/RDx3X1woZIg8MSf57qRrtqxNlV3GhuVTkL6gkxAJK0QIGLg1Z3ih7jqESmEf2G ZE5f2VRiMFnt6zh0CYW3XwAJsmxGp4AS2SVmYFCdKBeGeByWP2SvpJRphKH6QA== Date: Wed, 10 Jul 2024 14:29:46 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240710122946.GG4991@pb2> References: <20240709093437.16563-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 In-Reply-To: <20240709093437.16563-1-ffmpeg@haasn.xyz> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_scale: fix frame lifetimes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5117958380768589725==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5117958380768589725== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y52ms2kKCoiSthOi" Content-Disposition: inline --y52ms2kKCoiSthOi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2024 at 11:34:36AM +0200, Niklas Haas wrote: > From: Niklas Haas >=20 > scale_frame() inconsistently handled the lifetime of `in`. Fixes a > possible double free and a possible memory leak. >=20 > The new code always has `scale_frame` take over ownership of the input > frame. I first tried writing this code in a way where the calling code > retains ownership, but this is nontrivial due to the presence of the > no-op short-circuit condition in which the input frame is directly > returned. (As an alternative, we could use av_frame_clone() instead, but > I wanted to avoid touching the original behavior in this commit) > --- > libavfilter/vf_scale.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) patchset LGTM thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB During times of universal deceit, telling the truth becomes a revolutionary act. -- George Orwell --y52ms2kKCoiSthOi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZo5+twAKCRBhHseHBAsP q4jnAJ9+e2LlZCC1e336OJOD9YCwfFgFrACfS9zW0rBZOhBen2pOOH9/mEqDyT4= =kV1v -----END PGP SIGNATURE----- --y52ms2kKCoiSthOi-- --===============5117958380768589725== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5117958380768589725==--