Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_scale: fix frame lifetimes

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 999 bytes --]

On Tue, Jul 09, 2024 at 11:34:36AM +0200, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> scale_frame() inconsistently handled the lifetime of `in`. Fixes a
> possible double free and a possible memory leak.
> 
> The new code always has `scale_frame` take over ownership of the input
> frame. I first tried writing this code in a way where the calling code
> retains ownership, but this is nontrivial due to the presence of the
> no-op short-circuit condition in which the input frame is directly
> returned. (As an alternative, we could use av_frame_clone() instead, but
> I wanted to avoid touching the original behavior in this commit)
> ---
>  libavfilter/vf_scale.c | 29 +++++++++++++++++------------
>  1 file changed, 17 insertions(+), 12 deletions(-)

patchset LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".