From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81A2F4BA01 for ; Tue, 9 Jul 2024 13:28:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 794C768DCAE; Tue, 9 Jul 2024 16:28:18 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3B6168DCAE for ; Tue, 9 Jul 2024 16:28:11 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 06DA3240004 for ; Tue, 9 Jul 2024 13:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720531691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aNmoec7Cjcx/Ipc02r/FBmgz+2McoWHBzikwkTIDiaY=; b=fFb6lKaHMo5qXKAZrwlQtHFivrvf9gVyqKn+yKOucKrE/DeMUEgLZVn4tNIoUrHs53IsTT j8zMP6QVvA73cZoyi2XCXhOjpUSKnCMwrL7uNZRJQIsbPzoA0akYzBFbRbVboN2eF5sTTR GgFC7v230KTrP/0L+6FL9YILzphTitf0UPzX7J7N4Ay4cW16ZA2je5YcVLnhhTajlkKleM 7fNKC2ZIjrwYqxv+7aKlJ8ewYRYuE0AyUK2KL213CBmlEa998wNk04xsvSjBauR5iAVQQ4 pEoErEkrrFxySnJLAAFaAW5Apvr2KU/N5d3vAOuoEMdQq0Su8gA077VG9VNjLA== Date: Tue, 9 Jul 2024 15:28:10 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20240709132810.GA4991@pb2> References: <20240709113626.1836680-1-michael@niedermayer.cc> <172053107806.21847.11044848590089039731@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <172053107806.21847.11044848590089039731@lain.khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avutil/imgutils: av_image_check_size2() ensure width and height fit in 32bit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1271973208760100194==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1271973208760100194== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XgWkusiZDs53F1ax" Content-Disposition: inline --XgWkusiZDs53F1ax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2024 at 03:17:58PM +0200, Anton Khirnov wrote: > > ensure width and height fit in 32bit >=20 > why? because not everyone wants undefined behavior because not everyone wants security issues because we dont support width and height > 32bit and its easier to check in= a central place because the changed codes purpose is to check if the image paramaters are within what we support, and width of 100 billion is not. You can try all encoders with 100billion width. Then try to decode. Iam curious, how many work, how many fail and how they fail how many invalid bitstreams with no warning, how many undefined behavio= rs, ... Simply building FFmpeg on a platform with 64bit ints doesnt update ISO and ITU standards to allow larger values thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. --XgWkusiZDs53F1ax Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZo065gAKCRBhHseHBAsP q0AQAJ9c1aT94ifbYt9E+zRAJGuQld+STwCfYGwdm3qfDnBx4/iRUKL+zoyOukk= =SNIN -----END PGP SIGNATURE----- --XgWkusiZDs53F1ax-- --===============1271973208760100194== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1271973208760100194==--