From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: add optional "ref" input
Date: Mon, 8 Jul 2024 23:01:51 +0200
Message-ID: <20240708210151.GJ1904408@pb2> (raw)
In-Reply-To: <20240503122653.DDEB9412652@natalya.videolan.org>
[-- Attachment #1.1: Type: text/plain, Size: 1615 bytes --]
Hi
On Fri, May 03, 2024 at 12:26:52PM +0000, Niklas Haas wrote:
> ffmpeg | branch: master | Niklas Haas <git@haasn.dev> | Wed Apr 24 12:03:00 2024 +0200| [bb8044581366fe286e16b14515d873979133dbda] | committer: Niklas Haas
>
> avfilter/vf_scale: add optional "ref" input
>
> This is automatically enabled if the width/height expressions reference
> any ref_* variable. This will ultimately serve as a more principled
> replacement for the fundamentally broken scale2ref.
>
> See-Also: https://trac.ffmpeg.org/ticket/10795
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bb8044581366fe286e16b14515d873979133dbda
[...]
> ret = scale_frame(ctx->inputs[0], in, &out);
> if (out) {
> @@ -933,6 +1053,9 @@ static int do_scale(FFFrameSync *fs)
> return ff_filter_frame(outlink, out);
> }
>
> +err:
> + if (ret < 0)
> + av_frame_free(&in);
double free
this can be already freed in
out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
if (!out) {
av_frame_free(&in);
return AVERROR(ENOMEM);
}
Also the interaction of these functions is a bit complex
(which is why iam not proposing a fix but rather point this out
also as you are working on the scale code ...)
Found by coverity: CID1596782 Double free
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
parent reply other threads:[~2024-07-08 21:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240503122653.DDEB9412652@natalya.videolan.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708210151.GJ1904408@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git